Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jsonschema package to V4 #2050

Merged
merged 6 commits into from
Jun 24, 2022

Conversation

blackbird7112
Copy link
Contributor

📝 Description

Type: 🪲 bugfix

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

Attempt to update the jsonschema package to v4 and handle the new bugs introduced. Link to issue.

📌 Resources

Examples, notebooks, and links to useful references.
https://python-jsonschema.readthedocs.io/en/v3.2.0/validate/#the-validator-interface

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jun 11, 2022

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@blackbird7112 blackbird7112 marked this pull request as ready for review June 15, 2022 19:35
@blackbird7112
Copy link
Contributor Author

I have put the extra yaml file for now so that it can be used to test the PR. I will remove it before the PR merges

@andrewfullard
Copy link
Contributor

Good work on the validator. However, the environment file should be merged with the existing one unless somebody told you otherwise

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #2050 (db20fd5) into master (e8458b3) will increase coverage by 0.01%.
The diff coverage is 94.44%.

❗ Current head db20fd5 differs from pull request most recent head 715ad5e. Consider uploading reports for the commit 715ad5e to get more accurate results

@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
+ Coverage   58.34%   58.36%   +0.01%     
==========================================
  Files          76       76              
  Lines        8593     8597       +4     
==========================================
+ Hits         5014     5018       +4     
  Misses       3579     3579              
Impacted Files Coverage Δ
tardis/transport/calculate_distances.py 34.88% <ø> (ø)
tardis/transport/frame_transformations.py 49.01% <ø> (ø)
tardis/transport/r_packet_transport.py 20.00% <66.66%> (ø)
tardis/io/config_validator.py 90.47% <100.00%> (+1.00%) ⬆️
...lo_numba/continuum/r_packet_transport_continuum.py 15.15% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/estimators.py 41.37% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/interaction.py 28.00% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/r_packet.py 50.00% <100.00%> (ø)
.../montecarlo/montecarlo_numba/single_packet_loop.py 26.86% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/vpacket.py 21.78% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@blackbird7112
Copy link
Contributor Author

Updated the existing yaml and removed the testing yaml.

@epassaro
Copy link
Member

epassaro commented Jun 15, 2022

@rohithvarma3000 You also need to render both lockfiles by installing conda-lock and doing conda lock render conda-lock.yml.

Push both lockfiles to this pull request and see if tests pass. As you can see, the tests.yml workflow runs tests in an environment made with the lockfiles and not with tardis_env3.yml.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

1 similar comment
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@blackbird7112
Copy link
Contributor Author

@epassaro I have regenerated the lockfiles and pushed them to the branch.

@epassaro
Copy link
Member

@epassaro I have regenerated the lockfiles and pushed them to the branch.

Please rebase your pull request.

@andrewfullard
Copy link
Contributor

The lockfile has had a win-64 platform added. Was this intentional? We don't officially support Windows right now. @epassaro this is potentially a problem.

@epassaro
Copy link
Member

The lockfile has had a win-64 platform added. Was this intentional? We don't officially support Windows right now. @epassaro this is potentially a problem.

Hi @rohithvarma3000, check the pre-release.yml workflow and look for the correct command to lock files only for linux/osx and then render again

@blackbird7112
Copy link
Contributor Author

Thanks for the suggestion @epassaro. I have made the necessary changes to the PR.

@epassaro
Copy link
Member

This looks good to me @andrewfullard , I approved the pull request.

@andrewfullard andrewfullard merged commit de4a3ac into tardis-sn:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants