-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jsonschema package to V4 #2050
Conversation
*beep* *bop* Hi, human. The Click here to see your results. |
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
I have put the extra yaml file for now so that it can be used to test the PR. I will remove it before the PR merges |
Good work on the validator. However, the environment file should be merged with the existing one unless somebody told you otherwise |
Codecov Report
@@ Coverage Diff @@
## master #2050 +/- ##
==========================================
+ Coverage 58.34% 58.36% +0.01%
==========================================
Files 76 76
Lines 8593 8597 +4
==========================================
+ Hits 5014 5018 +4
Misses 3579 3579
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
Updated the existing yaml and removed the testing yaml. |
@rohithvarma3000 You also need to render both lockfiles by installing Push both lockfiles to this pull request and see if tests pass. As you can see, the |
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
1 similar comment
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
@epassaro I have regenerated the lockfiles and pushed them to the branch. |
Please rebase your pull request. |
c23e659
to
a2283fe
Compare
The lockfile has had a |
Hi @rohithvarma3000, check the |
a2283fe
to
715ad5e
Compare
Thanks for the suggestion @epassaro. I have made the necessary changes to the PR. |
This looks good to me @andrewfullard , I approved the pull request. |
📝 Description
Type: 🪲
bugfix
Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.
Also, link issues affected by this pull request by using the keywords:
close
,closes
,closed
,fix
,fixes
,fixed
,resolve
,resolves
orresolved
.Attempt to update the jsonschema package to v4 and handle the new bugs introduced. Link to issue.
📌 Resources
Examples, notebooks, and links to useful references.
https://python-jsonschema.readthedocs.io/en/v3.2.0/validate/#the-validator-interface
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label