-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-write download_from_url
using Astropy's download_file
#1991
Merged
wkerzendorf
merged 5 commits into
tardis-sn:master
from
epassaro:io/astropy-download-file
May 11, 2022
Merged
Re-write download_from_url
using Astropy's download_file
#1991
wkerzendorf
merged 5 commits into
tardis-sn:master
from
epassaro:io/astropy-download-file
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1991 +/- ##
==========================================
+ Coverage 59.99% 60.13% +0.14%
==========================================
Files 70 70
Lines 8111 8108 -3
==========================================
+ Hits 4866 4876 +10
+ Misses 3245 3232 -13
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
epassaro
changed the title
Download atomic data using Astropy's
Re-write Apr 29, 2022
download_file
functiondownload_from_url
using Astropy's download_file
epassaro
force-pushed
the
io/astropy-download-file
branch
from
May 2, 2022 20:29
1e076e0
to
41b1f89
Compare
epassaro
force-pushed
the
io/astropy-download-file
branch
from
May 2, 2022 21:39
41b1f89
to
eb2d655
Compare
*beep* *bop* Hi, human. The Click here to see your results. |
andrewfullard
approved these changes
May 9, 2022
Rodot-
approved these changes
May 11, 2022
wkerzendorf
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new Astropy's
download_file
function allows us to download files from Azure, this wasn't possible with the previous function. The atomic data is a LFS object, so would be good to save quota in this moment.This function also has:
The bad news is I couldn't make
tqdm
work, but maybe it's a good first issue for someone else.Motivation and context
How has this been tested?
Examples
Type of change
Checklist