Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write download_from_url using Astropy's download_file #1991

Merged
merged 5 commits into from
May 11, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Apr 29, 2022

Description

The new Astropy's download_file function allows us to download files from Azure, this wasn't possible with the previous function. The atomic data is a LFS object, so would be good to save quota in this moment.

This function also has:

  • Cache
  • Mirrors

The bad news is I couldn't make tqdm work, but maybe it's a good first issue for someone else.

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1991 (25f925f) into master (713c9db) will increase coverage by 0.14%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
+ Coverage   59.99%   60.13%   +0.14%     
==========================================
  Files          70       70              
  Lines        8111     8108       -3     
==========================================
+ Hits         4866     4876      +10     
+ Misses       3245     3232      -13     
Impacted Files Coverage Δ
tardis/io/atom_data/atom_web_download.py 40.00% <0.00%> (-2.11%) ⬇️
tardis/io/util.py 78.26% <60.00%> (+6.26%) ⬆️
tardis/io/atom_data/base.py 89.71% <0.00%> (+0.17%) ⬆️
tardis/plasma/standard_plasmas.py 74.48% <0.00%> (+0.26%) ⬆️
tardis/plasma/properties/atomic.py 56.17% <0.00%> (+1.07%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro epassaro changed the title Download atomic data using Astropy's download_file function Re-write download_from_url using Astropy's download_file Apr 29, 2022
@epassaro epassaro self-assigned this Apr 29, 2022
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The build-docs workflow has succeeded ✔️

Click here to see your results.

@wkerzendorf wkerzendorf merged commit 0ece835 into tardis-sn:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants