Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU Options #1919

Merged
merged 4 commits into from
Mar 3, 2022
Merged

GPU Options #1919

merged 4 commits into from
Mar 3, 2022

Conversation

KevinCawley
Copy link
Contributor

@KevinCawley KevinCawley commented Mar 3, 2022

Allows a user to select which method the formal_integral should run.

Description

Added the compute option in schemas for the config.yml so now users can add compute under spectrum/integrated to select different options for running the formal_integral. The other two are GPU and Automatic. GPU will try to use a NVIDIA Cuda GPU, and if none are available it will throw an error. Automatic will first try to find a GPU, and if none can be found it will default to running on numba. If GPU, CPU, or Automatic are not passed as arguments, it will throw an error for an invalid parameter. (All of them are set to be upper so user case is not an issue).

Motivation and context

Feature

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

1 similar comment
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@wkerzendorf wkerzendorf merged commit f541e73 into tardis-sn:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants