Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zenodo pipeline (2nd) #1789

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

epassaro
Copy link
Member

Description

Add explicit jupyter dependency again.

Motivation and context

See #1787.

This pipeline can't be tested through a PR, because uses a secret token to clone the secret repository and that token is not shared with pull requests. That's make it hard to debug.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1789 (4317d4c) into master (1994573) will not change coverage.
The diff coverage is n/a.

❗ Current head 4317d4c differs from pull request most recent head b7def11. Consider uploading reports for the commit b7def11 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1789   +/-   ##
=======================================
  Coverage   58.42%   58.42%           
=======================================
  Files          66       66           
  Lines        6684     6684           
=======================================
  Hits         3905     3905           
  Misses       2779     2779           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1994573...b7def11. Read the comment docs.

@epassaro epassaro merged commit acf9b60 into tardis-sn:master Aug 26, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants