Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hover Data in Plasma Convergence Plots #1778

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Aug 13, 2021

The hover data in plasma plots did not show luminosity data correctly. This fixes that.

Description

This PR fixes this data:
image

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #1778 (9faaf87) into master (e21ecf7) will not change coverage.
The diff coverage is n/a.

❗ Current head 9faaf87 differs from pull request most recent head 2f1cbf7. Consider uploading reports for the commit 2f1cbf7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1778   +/-   ##
=======================================
  Coverage   62.65%   62.65%           
=======================================
  Files          65       65           
  Lines        6036     6036           
=======================================
  Hits         3782     3782           
  Misses       2254     2254           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21ecf7...2f1cbf7. Read the comment docs.

Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jamesgillanders jamesgillanders merged commit 2bf1b66 into tardis-sn:master Aug 19, 2021
DhruvSondhi pushed a commit to DhruvSondhi/tardis that referenced this pull request Aug 21, 2021
DhruvSondhi pushed a commit to DhruvSondhi/tardis that referenced this pull request Aug 21, 2021
atharva-2001 added a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants