Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated widgets.py Changing all T's to temprature #1675

Closed
wants to merge 3 commits into from

Conversation

pokwer
Copy link

@pokwer pokwer commented Jun 28, 2021

Description
Updated widgets.py Changing all T's to temprature

Motivation and context
solving issue #1600

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #1675 (eab66bc) into master (c47a3df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1675   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          62       62           
  Lines        5732     5732           
=======================================
  Hits         3548     3548           
  Misses       2184     2184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47a3df...eab66bc. Read the comment docs.

@andrewfullard
Copy link
Contributor

Thanks for your first contribution! It looks like I need to clarify my issue, because the T I meant was the variable, not the labels on plots. Furthermore, you misspelled Temperature in your contribution.

@pokwer
Copy link
Author

pokwer commented Jun 29, 2021

Thanks for your first contribution! It looks like I need to clarify my issue, because the T I meant was the variable, not the labels on plots. Furthermore, you misspelled Temperature in your contribution.

can you tell me what files these variables are in so that I can change them?

@andrewfullard
Copy link
Contributor

You should search the files to find them :)

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@jaladh-singhal
Copy link
Member

We no longer support tardis/gui since we now have tardis/visulaization/widgets for the same.

@andrewfullard should we close it?

@andrewfullard andrewfullard removed the request for review from epassaro July 2, 2021 14:05
@andrewfullard andrewfullard marked this pull request as draft July 6, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants