Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use conda-forge packages instead of pypi #1664

Merged
merged 3 commits into from
Jun 25, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 23, 2021

Description
Use snakeviz and python-dokuwiki from conda-forge channel.

Motivation and context

We don't want pip dependencies.

How has this been tested?

  • Testing pipeline.
  • Other.

See: https://epassaro.github.io/tardis/branch/conda-forge-dokuwiki/io/output/profiling_example.html?highlight=profile

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@epassaro epassaro marked this pull request as draft June 23, 2021 22:25
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #1664 (22461a8) into master (05f759a) will not change coverage.
The diff coverage is n/a.

❗ Current head 22461a8 differs from pull request most recent head 4544b82. Consider uploading reports for the commit 4544b82 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1664   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          62       62           
  Lines        5732     5732           
=======================================
  Hits         3548     3548           
  Misses       2184     2184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f759a...4544b82. Read the comment docs.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jun 24, 2021

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

Copy link
Contributor

@KevinCawley KevinCawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works without needing it to be a pip dependency, nice.

@epassaro epassaro marked this pull request as ready for review June 24, 2021 19:24
@andrewfullard andrewfullard merged commit eaab7a1 into tardis-sn:master Jun 25, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* use conda-forge packages instead of pypi

* comment out dokuwiki (cf-staging)

* undo comment out dokuwiki (cf-staging) [build_docs]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants