Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test before make a new release #1635

Merged
merged 3 commits into from
Jun 11, 2021
Merged

test before make a new release #1635

merged 3 commits into from
Jun 11, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 8, 2021 •
edited
Loading

Description

  • Run tests before making the release (we do not want to release broken software!)
  • Use the tardis-bot endpoint
  • Make pre-releases for dev versions

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@epassaro epassaro marked this pull request as draft June 8, 2021 00:19
@epassaro epassaro marked this pull request as ready for review June 8, 2021 14:55
@tardis-bot
Copy link
Contributor

tardis-bot commented Jun 8, 2021 •
edited by andrewfullard
Loading

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

Rodot-
Rodot- approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

@codecov
Copy link

codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #1635 (5847346) into master (576038a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1635   +/-   ##
=======================================
  Coverage   67.13%   67.13%           
=======================================
  Files          73       73           
  Lines        6100     6100           
=======================================
  Hits         4095     4095           
  Misses       2005     2005

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576038a...5847346. Read the comment docs.

@andrewfullard andrewfullard merged commit 48b9938 into tardis-sn:master Jun 11, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
@epassaro
Run tests before making a new release (tardis-sn#1635)
6a2bc85 
* test before make a new release

* remove fetch depth just in case

* make prerelases by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rodot- Rodot- Rodot- approved these changes

@andrewfullard andrewfullard andrewfullard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epassaro @tardis-bot @Rodot- @andrewfullard