Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sponsors page of documentation #1584

Merged
merged 2 commits into from
May 25, 2021

Conversation

isaacgsmith
Copy link
Member

Added a sponsors page to the documentation as can be seen here.

Description

The sponsors page includes logos for Google, ESA, and NumFOCUS.

Motivation and context

Wolfgang requested that this page be added to the documentation.

How has this been tested?

  • Testing pipeline.
  • Other.
    Documentation build locally and on github.

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #1584 (64b0324) into master (7eca324) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1584   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          73       73           
  Lines        6147     6147           
=======================================
  Hits         4131     4131           
  Misses       2016     2016           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eca324...64b0324. Read the comment docs.

Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @smithis7 for making this so quick!

docs/sponsors.rst Show resolved Hide resolved
@andrewfullard andrewfullard merged commit 351cc8f into tardis-sn:master May 25, 2021
@Molkree
Copy link
Contributor

Molkree commented May 31, 2021

I don't see the contents of this page in Chrome, not even the We are grateful to the following organisations line.

image

It's just fine in Edge.

image

@isaacgsmith
Copy link
Member Author

I don't see the contents of this page in Chrome, not even the We are grateful to the following organisations line.

image

It's just fine in Edge.

image

That's very odd. It works fine for me in chrome. Does the page source appear correctly when you click "view page source" in chrome?

@Molkree
Copy link
Contributor

Molkree commented Jun 1, 2021

@smithis7, it seems so?
image

But the contents are 0px height
image

@KevinCawley
Copy link
Contributor

What type of device are you using to view it? And what is the standard dimensions of your screen?

@isaacgsmith isaacgsmith deleted the sponsor_doc branch June 1, 2021 14:54
@Molkree
Copy link
Contributor

Molkree commented Jun 1, 2021

Okay, I see why it happens, it's AdGuard.
This is a bit weird tho, it says that it blocked 0 ads, but if I disable it I can see everything on the page, so it's definitely the reason why.

@Molkree
Copy link
Contributor

Molkree commented Jun 1, 2021

For anyone interested, AdGuard has updated filters so it works correctly now.

atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* making sponsors page

* adding explanation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants