Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version number in docs #1540

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

epassaro
Copy link
Member

Description
Solves #1391

Motivation and context

I was porting the carsus doc to GA and suddenly realized what's happening. The checkout action from GA by default just fetches the latest commit, and the "old" astropy_helper version solver uses the number of commits to calculate the dev version. Using fetch-depth: 0 in the step args solves this issue.

How has this been tested?

  • Testing pipeline.
  • Other.

Tested in carsus documentation.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #1540 (10ef991) into master (a15551c) will not change coverage.
The diff coverage is n/a.

❗ Current head 10ef991 differs from pull request most recent head 024899e. Consider uploading reports for the commit 024899e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1540   +/-   ##
=======================================
  Coverage   69.06%   69.06%           
=======================================
  Files          68       68           
  Lines        6106     6106           
=======================================
  Hits         4217     4217           
  Misses       1889     1889           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15551c...024899e. Read the comment docs.

@andrewfullard andrewfullard merged commit 888575d into tardis-sn:master Apr 15, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants