Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ion contributions to SDEC plotter #1539

Merged
merged 21 commits into from
Apr 23, 2021

Commits on Mar 26, 2021

  1. Add catch for missing elements

    The elements coloured in the plot are determined via the absorption and emission. It's possible however, that these elements are not the same, e.g. if you specify a limited wavelength range. This could give an error if you try to plot an element not in the emission dataframe, for example. This adds a try statement to catch this case
    MarkMageeAstro committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    8b33836 View commit details
    Browse the repository at this point in the history
  2. Fixed typo

    MarkMageeAstro committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    d65ebcb View commit details
    Browse the repository at this point in the history
  3. Black formatting

    MarkMageeAstro committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    082c0c4 View commit details
    Browse the repository at this point in the history
  4. Fixed typo

    MarkMageeAstro committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    26078cd View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2021

  1. Add species column to packet df

    Added a new column to the packet dataframe that gives the species id. This combines the atomic and ion numbers into a unique id that will be used to group species later.
    MarkMageeAstro committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    7cf1464 View commit details
    Browse the repository at this point in the history
  2. Added species list parser

    Added parser to convert request species list into ids to be used by plotter
    MarkMageeAstro committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    7429924 View commit details
    Browse the repository at this point in the history
  3. Implement parser call

    Call species list parser function
    MarkMageeAstro committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    6952a19 View commit details
    Browse the repository at this point in the history
  4. Fixed parser

    Rearranged parser so it didn't crash if species_list was none
    MarkMageeAstro committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    cac5a30 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Implement MPL ion contributions

    Added in the ion contribution stuff for the mpl plotting.
    Also added a new function to get the colorbar labels. This is necessary to determine how many unique colours there should be
    MarkMageeAstro committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    494e615 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a9c708 View commit details
    Browse the repository at this point in the history
  3. Implement plotly ion contributions

    Added colouring for ion contributions in plotly figures
    MarkMageeAstro committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    6c56d4c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    607f155 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Fixed df bug and added comments

    Fixed bug in the absorption and emission df calculations. Now they elements should be handled correctly so there won't be errors if a species appears in emission and not absorption, and vice versa
    
    Added comments throughout
    MarkMageeAstro committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    385c5b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a05a688 View commit details
    Browse the repository at this point in the history
  3. Black formatting

    MarkMageeAstro committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    f97307b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Added colour function

    Added a new function to work out what colours will be plotted. This was originally repeated multiple times in the code, but now it's a single function that's called multiple times
    
    Also fixed a bug in the absorption luminosities dataframe
    MarkMageeAstro committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    aaa0af8 View commit details
    Browse the repository at this point in the history
  2. Address review comments

    Change name of some variables and fixed some typos.
    MarkMageeAstro committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    a83fa81 View commit details
    Browse the repository at this point in the history
  3. Change print to logger

    MarkMageeAstro committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    ccb9507 View commit details
    Browse the repository at this point in the history
  4. Black formatting

    MarkMageeAstro committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    ac88aa3 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Configuration menu
    Copy the full SHA
    3ed5933 View commit details
    Browse the repository at this point in the history
  2. Black formatting

    MarkMageeAstro committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    c5362f7 View commit details
    Browse the repository at this point in the history