-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ion contributions to SDEC plotter #1539
Merged
jaladh-singhal
merged 21 commits into
tardis-sn:master
from
MarkMageeAstro:sdec-ion-contributions
Apr 23, 2021
Merged
Add ion contributions to SDEC plotter #1539
jaladh-singhal
merged 21 commits into
tardis-sn:master
from
MarkMageeAstro:sdec-ion-contributions
Apr 23, 2021
Commits on Mar 26, 2021
-
Add catch for missing elements
The elements coloured in the plot are determined via the absorption and emission. It's possible however, that these elements are not the same, e.g. if you specify a limited wavelength range. This could give an error if you try to plot an element not in the emission dataframe, for example. This adds a try statement to catch this case
Configuration menu - View commit details
-
Copy full SHA for 8b33836 - Browse repository at this point
Copy the full SHA 8b33836View commit details -
Configuration menu - View commit details
-
Copy full SHA for d65ebcb - Browse repository at this point
Copy the full SHA d65ebcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 082c0c4 - Browse repository at this point
Copy the full SHA 082c0c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26078cd - Browse repository at this point
Copy the full SHA 26078cdView commit details
Commits on Apr 4, 2021
-
Add species column to packet df
Added a new column to the packet dataframe that gives the species id. This combines the atomic and ion numbers into a unique id that will be used to group species later.
Configuration menu - View commit details
-
Copy full SHA for 7cf1464 - Browse repository at this point
Copy the full SHA 7cf1464View commit details -
Added parser to convert request species list into ids to be used by plotter
Configuration menu - View commit details
-
Copy full SHA for 7429924 - Browse repository at this point
Copy the full SHA 7429924View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6952a19 - Browse repository at this point
Copy the full SHA 6952a19View commit details -
Rearranged parser so it didn't crash if species_list was none
Configuration menu - View commit details
-
Copy full SHA for cac5a30 - Browse repository at this point
Copy the full SHA cac5a30View commit details
Commits on Apr 5, 2021
-
Implement MPL ion contributions
Added in the ion contribution stuff for the mpl plotting. Also added a new function to get the colorbar labels. This is necessary to determine how many unique colours there should be
Configuration menu - View commit details
-
Copy full SHA for 494e615 - Browse repository at this point
Copy the full SHA 494e615View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a9c708 - Browse repository at this point
Copy the full SHA 0a9c708View commit details -
Implement plotly ion contributions
Added colouring for ion contributions in plotly figures
Configuration menu - View commit details
-
Copy full SHA for 6c56d4c - Browse repository at this point
Copy the full SHA 6c56d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 607f155 - Browse repository at this point
Copy the full SHA 607f155View commit details
Commits on Apr 14, 2021
-
Fixed df bug and added comments
Fixed bug in the absorption and emission df calculations. Now they elements should be handled correctly so there won't be errors if a species appears in emission and not absorption, and vice versa Added comments throughout
Configuration menu - View commit details
-
Copy full SHA for 385c5b5 - Browse repository at this point
Copy the full SHA 385c5b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a05a688 - Browse repository at this point
Copy the full SHA a05a688View commit details -
Configuration menu - View commit details
-
Copy full SHA for f97307b - Browse repository at this point
Copy the full SHA f97307bView commit details
Commits on Apr 22, 2021
-
Added a new function to work out what colours will be plotted. This was originally repeated multiple times in the code, but now it's a single function that's called multiple times Also fixed a bug in the absorption luminosities dataframe
Configuration menu - View commit details
-
Copy full SHA for aaa0af8 - Browse repository at this point
Copy the full SHA aaa0af8View commit details -
Change name of some variables and fixed some typos.
Configuration menu - View commit details
-
Copy full SHA for a83fa81 - Browse repository at this point
Copy the full SHA a83fa81View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccb9507 - Browse repository at this point
Copy the full SHA ccb9507View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac88aa3 - Browse repository at this point
Copy the full SHA ac88aa3View commit details
Commits on Apr 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3ed5933 - Browse repository at this point
Copy the full SHA 3ed5933View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5362f7 - Browse repository at this point
Copy the full SHA c5362f7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.