Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TARDIS ref parameter on pipeline template #1534

Closed
wants to merge 1 commit into from

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Apr 13, 2021

Description

This PR will allow pipelines to run unit test or reference data tests with a specific TARDIS version given by a reference (commit, tag, branch). This has some limitations due to the nature of conda environments: you can checkout and install any version of the environment file you want, but this environment is solved differently (or maybe unsolvable). A solution for this needs to be discussed with the core team. See: conda/conda#7248.

Motivation and Context

Improves the current pipeline template.

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #1534 (b896d8d) into master (c14b2cd) will not change coverage.
The diff coverage is n/a.

❗ Current head b896d8d differs from pull request most recent head ea3ae2c. Consider uploading reports for the commit ea3ae2c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1534   +/-   ##
=======================================
  Coverage   67.57%   67.57%           
=======================================
  Files          68       68           
  Lines        6103     6103           
=======================================
  Hits         4124     4124           
  Misses       1979     1979           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14b2cd...ea3ae2c. Read the comment docs.

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see the documentation of this feature included as part of the PR

@epassaro
Copy link
Member Author

Ok. Notice that this feature has some limitations due to the reproducibility of old environments (see TEP013).

@epassaro epassaro marked this pull request as draft April 28, 2021 14:57
@epassaro epassaro closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants