Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected csvy model files #1483

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Corrected csvy model files #1483

merged 1 commit into from
Apr 5, 2021

Conversation

antreev-brar
Copy link
Contributor

This PR aims to correct the csvy files csvy_full.csvy and csvy_full_rad.csvy

Description

Changes made to the code are:

  • Introduced the line model_isotope_time_0: 0 day in .csvy files

Motivation and Context

When tardis model is simulated using the csvy format file examples provided in repository, it gives an error. In the tardis/io/schemas/csvy_model.yml , it's description states:

model_isotope_time_0:
type: quantity
description: Initial time for isotope decay. Set to 0 for no isotopes.

Also, various other csvy files in the repository like tardis/tardis/model/tests/data/exponential_csvy.csvy and tardis/tardis/model/tests/data/uniform_csvy.csvy have these corrections.

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

I checked it by running unit tests on it with python setup.py test that gave the following output on my local machine.

  • 156 passed, 1254 skipped, 6 xpassed in 7.80s

Screenshots (if appropriate):

Before the changes:

Screenshot 2021-03-14 at 2 25 26 PM

After the changes:

Screenshot 2021-03-14 at 2 31 29 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #1483 (28d7959) into master (9497250) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
- Coverage   71.13%   70.00%   -1.14%     
==========================================
  Files          67       67              
  Lines        5523     5314     -209     
==========================================
- Hits         3929     3720     -209     
  Misses       1594     1594              
Impacted Files Coverage Δ
...dis/tardis/montecarlo/montecarlo_numba/r_packet.py 23.15% <0.00%> (-7.83%) ⬇️
.../tardis/montecarlo/montecarlo_numba/interaction.py 24.32% <0.00%> (-5.68%) ⬇️
.../montecarlo/montecarlo_numba/single_packet_loop.py 24.56% <0.00%> (-3.78%) ⬇️
...rdis/tardis/montecarlo/montecarlo_numba/vpacket.py 15.00% <0.00%> (-2.48%) ⬇️
tardis/tardis/plasma/properties/util/macro_atom.py 30.00% <0.00%> (-2.26%) ⬇️
tardis/tardis/visualization/tools/sdec_plot.py 14.35% <0.00%> (-1.94%) ⬇️
...rdis/montecarlo/montecarlo_numba/tests/conftest.py 91.11% <0.00%> (-1.88%) ⬇️
tardis/tardis/plasma/properties/nlte.py 39.21% <0.00%> (-1.74%) ⬇️
...s/tardis/montecarlo/montecarlo_numba/macro_atom.py 43.75% <0.00%> (-1.71%) ⬇️
tardis/tardis/montecarlo/spectrum.py 70.00% <0.00%> (-1.70%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9497250...1407a7a. Read the comment docs.

@andrewfullard
Copy link
Contributor

Thanks for this fix!

@marxwillia
Copy link
Contributor

Thanks for fixing this! Can you please clean up the commit history? Since this is a very simple PR there should only be one commit.

@antreev-brar antreev-brar reopened this Mar 15, 2021
@antreev-brar
Copy link
Contributor Author

@marxwillia I have made the requested changes, can you review it?

@andrewfullard andrewfullard merged commit 011f9b7 into tardis-sn:master Apr 5, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants