Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update changelog workflow #1432

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jan 28, 2021

Description

  • Disable action for forks.
  • Use TARDIS bot token to push.

Motivation and Context

@KevinCawley noticed the workflow was running on forks. Ironically, the workflow fails on tardis main repo because our master branch is write-protected (requires at least one approval before merging). The TARDIS bot has enough rights to do it.

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

It's not possible to test these changes before merging 🤞 .

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1432 (4e97130) into master (4c346f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1432   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files          67       67           
  Lines        5521     5521           
=======================================
  Hits         3929     3929           
  Misses       1592     1592           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c346f0...4e97130. Read the comment docs.

@epassaro epassaro force-pushed the fix-update-changelog branch 3 times, most recently from bb46a0f to 64b69b7 Compare January 30, 2021 13:40
@wkerzendorf wkerzendorf merged commit 3ac1435 into tardis-sn:master Jan 30, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants