Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C formal integral #1358

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Conversation

chvogl
Copy link
Contributor

@chvogl chvogl commented Nov 25, 2020

Description

This PR makes it possible to run the formal integrator again, which is currently not working.

Motivation and Context

The formal integrator is used in the generation of the documentation and it is a useful feature that users
might want to use. It is important to have a working version.

How Has This Been Tested?

I ran the code and it worked. Hopefully the tests will pass.

Screenshots (if appropriate):

Screenshot 2020-11-25 at 17 23 44

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1358 (90d3a6a) into master (f07228f) will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
+ Coverage   71.24%   71.77%   +0.53%     
==========================================
  Files          66       66              
  Lines        5077     5077              
==========================================
+ Hits         3617     3644      +27     
+ Misses       1460     1433      -27     
Impacted Files Coverage Δ
tardis/tardis/montecarlo/formal_integral.py 25.26% <0.00%> (+9.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07228f...90d3a6a. Read the comment docs.

@andrewfullard andrewfullard merged commit ca7cfcb into tardis-sn:master Nov 25, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants