Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for release pipeline #1330

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Oct 27, 2020

Description

  • Set destination path for self repo (tardis main repo in this case)
  • Minor changes to step names
  • Update documentation

Motivation and Context

Release pipeline failed because Azure uses different folder structure when fetching multiple repos (see here).

The main goal of this PR is to use the same folder structure across all Azure pipeline, independently of how many repositories we check out.

How Has This Been Tested?

Running the testing pipeline without checking out reference data. Worked.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1330   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files          46       46           
  Lines        3799     3799           
=======================================
  Hits         3099     3099           
  Misses        700      700           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a443a9d...7cb93bc. Read the comment docs.

@epassaro
Copy link
Member Author

This is ready for review.

@epassaro epassaro mentioned this pull request Oct 27, 2020
8 tasks
@epassaro epassaro added the CI/CD label Oct 28, 2020
@wkerzendorf wkerzendorf merged commit 2f317ca into tardis-sn:master Nov 4, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* explicitly set path for self repo

* fix path

* fix path

* test single repo checkout

* (undo) test single repo checkout

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants