Fix to deal with possible problem in end of line list #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssim as discussed looks right |
wkerzendorf
added a commit
that referenced
this pull request
Apr 14, 2014
Fix to deal with possible problem in end of line list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a problem with packets getting outside the line list in pure H test model. Tracked to issues in the binary_search.
Fixes proposed here (and noted in change log). I will open a issue - we should also introduce some tests on the binary search / handling of last line position. But in the meantime we should considering merging my fixes, if everyone agrees that the previous was wrong and that this is correct.
@wkerzendorf @mklauser Please look and merge if you agree.