Add skip condition if QT_API is no set (issue #1101) #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wkerzendorf Could you please reopen this? |
|
Ok, so this is ready to merge I think |
sashank27
reviewed
May 9, 2020
Co-authored-by: Sashank Mishra <[email protected]>
Co-authored-by: Sashank Mishra <[email protected]>
ebjordi
commented
May 13, 2020
| @@ -1066,13 +1066,13 @@ def __init__(self, tablemodel, config=None, atom_data=None, parent=None): | |||
| """ | |||
|
|
|||
| #assumes that qt has already been initialized by starting IPython | |||
| #with the flag "--pylab=qt" | |||
| #with the flag "--pylab=qt"gut | |||
There was a problem hiding this comment.
Fix this typo later
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
Add skip condition if QT_API is no set (issue tardis-sn#1101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest tardisfails on import of gui interface and widgets if QT_API variable is not setDescription
The issue appears on import (and I still don't how skipimport would work but I'll revisit at some point). I changed the call so that the import wouldn't check inside the module until needed for the test by importing the whole module. Following this some of the objects inside the function have to be called more explicitly.
I added the skipif decorator from pytest. The test now skips when the variable QT_API is not defined, but I'm not sure how the
pytest tardisshould proceed when the variable is defined. When I define QT_API either way on my master branch the test still skips, which I suppose is the expected behaviour because I didn't modify anything there.On a different commit I modified the functions interface and widgets to change how the Iphyton library calls specific functions, as can be seen this changes a qt4 to a qt5 and is purely for consistency, given that the functions are the same.
Motivation and Context
Adresses #1101
How Has This Been Tested?
Run
pytest tardisand the test now skips when QT_API is not declared.Run again for the Iphyton calls change.
Giving( to save as reference)
263 passed, 1119 skipped, 1 xfailed in 24.38 seconds
Screenshots (if appropriate):
Types of changes
All input is appreciated.