Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests for tardis.util from io/tests/test_config_reader to tests/test_util.py #88

Closed
wkerzendorf opened this issue Mar 2, 2014 · 2 comments
Labels

Comments

@wkerzendorf
Copy link
Member

The tests are located in the wrong place.
Also add tests for 'si2' and other species without space.

There are functions in test_config_reader (like test_species_string_to_species() that test functions that are located in util. These functions should be moved to test_util.py.

@thegyro
Copy link
Contributor

thegyro commented Mar 14, 2014

Thanks for the clarification! The function test_element_symbol2atomic_number is present at both test_config_reader.py as well as test_util.py. It looks like both are doing the same job (just that the former seems to check for more elements rather than just silicon and it is covering more ground/cases than the latter). I would say to remove the current test_element_symbol2atomic_number function written in test_util.py and replace it with the one in test_config_reader.

thegyro added a commit to thegyro/tardis that referenced this issue Mar 14, 2014
…l.py from test_config_reader.py to test_util.py
thegyro added a commit to thegyro/tardis that referenced this issue Mar 14, 2014
thegyro added a commit to thegyro/tardis that referenced this issue Mar 14, 2014
thegyro added a commit to thegyro/tardis that referenced this issue Mar 14, 2014
thegyro added a commit to thegyro/tardis that referenced this issue Mar 14, 2014
thegyro added a commit to thegyro/tardis that referenced this issue Mar 15, 2014
wkerzendorf added a commit that referenced this issue Mar 17, 2014
Fix for Issue #88: Moved test functions for tardis.util from test_config_reader
@unoebauer
Copy link
Contributor

FYI @wkerzendorf: Move has been performed - no longer an issue - closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants