Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing C2 in vald #422

Merged
merged 5 commits into from
Nov 13, 2024
Merged

fix missing C2 in vald #422

merged 5 commits into from
Nov 13, 2024

Conversation

jvshields
Copy link
Contributor

Fixing a small bug in the vald molecule linelist parsing that caused it to miss diatomic molecules that have the same base atom - mostly just C2.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (3403655) to head (1a2cfe4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   66.68%   67.07%   +0.38%     
==========================================
  Files          46       46              
  Lines        3497     3547      +50     
==========================================
+ Hits         2332     2379      +47     
- Misses       1165     1168       +3     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment on what the regex means would be nice

@jvshields jvshields merged commit 487efcd into master Nov 13, 2024
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants