Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Carsus environment #406

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Update the Carsus environment #406

merged 11 commits into from
Sep 23, 2024

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Sep 9, 2024

📝 Description

Type: ☣️ breaking change | 🎢 infrastructure

Cleans up the Carsus environment and builds lock files for each architecture. Current major issues are 1) ChiantiPy is broken, see linked issue 2) TARDIS atomic data cannot be exported.

  1. has been resolved with a hopefully temporary fix.

📌 Resources

chianti-atomic/ChiantiPy#466

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@andrewfullard andrewfullard added 🔥 dependencies Pull requests that update a dependency file labels Sep 9, 2024
@andrewfullard andrewfullard self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 83.05085% with 10 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (09bd62c) to head (5907f1b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
carsus/io/output/levels_lines.py 0.00% 8 Missing ⚠️
carsus/io/output/base.py 0.00% 1 Missing ⚠️
carsus/io/output/photo_ionization.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage   58.30%   66.68%   +8.38%     
==========================================
  Files          30       46      +16     
  Lines        2758     3497     +739     
==========================================
+ Hits         1608     2332     +724     
- Misses       1150     1165      +15     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@afloers
Copy link
Contributor

afloers commented Sep 16, 2024

  1. TARDIS atomic data cannot be exported.
    Do you mean the .to_hdf method? Which package breaks this functionality?

@wkerzendorf wkerzendorf merged commit 3403655 into master Sep 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-docs dependencies Pull requests that update a dependency file 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants