-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Workflow to check compatibility of TARDIS and Carsus #313
Add Workflow to check compatibility of TARDIS and Carsus #313
Conversation
change env file path change env file path change path again change path again skip first step path again Package path
Fix atom data path
repo path test
Fix package path
Fix notebook path Fix notebook path Require carsus build to run again before running tardis build
Fix output format of atom data notebook Fix atom data path again Print atom data path Fix atom data path
…the new atomic data file
Fix atomic data path
3c8afc3
to
b808e38
Compare
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
- Coverage 74.44% 73.25% -1.20%
==========================================
Files 23 25 +2
Lines 2614 3174 +560
==========================================
+ Hits 1946 2325 +379
- Misses 668 849 +181
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fb6c3b1
to
890c619
Compare
4d5dc87
to
336cfb0
Compare
336cfb0
to
0da5cbb
Compare
cd480eb
to
57be609
Compare
16a76c3
to
612586f
Compare
f09cb0f
to
dafafd3
Compare
ae4d133
to
c7aaaeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
📝 Description
Type: 🚀
feature
🚦testing
This PR adds a workflow to check if the current Carsus atomic file makes any difference to the TARDIS spectrum and other data.
The workflow takes the following steps to do this:
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label