-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Eslint to v9 #697
Upgrade Eslint to v9 #697
Conversation
migrate config from .eslintrc.json and .eslintignore to eslint.config.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Those catch(err)
issues could be converted to not require the disable.
Cloudflare build fails like so:
|
Deploying chatcraft-org with Cloudflare Pages
|
This is because I upgraded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
Fixes #689
This PR upgrades Eslint to v9 and moves to a flat config.
All plugins are now up to date and compatible with the new Eslint flat config. The exception was
eslint-plugin-react-hooks
where I had to use the latest rc version (facebook/react#28313 (comment)).I started the upgrade process with the configuration migrator and then went through each plugin and used the recommended configuration setup found in the docs (while making sure all the original chatcraft custom configurations are kept).