Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Eslint to v9 #697

Merged
merged 9 commits into from
Oct 8, 2024
Merged

Upgrade Eslint to v9 #697

merged 9 commits into from
Oct 8, 2024

Conversation

menghif
Copy link
Collaborator

@menghif menghif commented Oct 7, 2024

Fixes #689

This PR upgrades Eslint to v9 and moves to a flat config.

All plugins are now up to date and compatible with the new Eslint flat config. The exception was eslint-plugin-react-hooks where I had to use the latest rc version (facebook/react#28313 (comment)).

I started the upgrade process with the configuration migrator and then went through each plugin and used the recommended configuration setup found in the docs (while making sure all the original chatcraft custom configurations are kept).

Copy link
Collaborator

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Those catch(err) issues could be converted to not require the disable.

src/components/CodeHeader.tsx Outdated Show resolved Hide resolved
@humphd
Copy link
Collaborator

humphd commented Oct 7, 2024

Cloudflare build fails like so:


16:56:24.488 | > [email protected] build /opt/buildhome/repo
-- | --
16:56:24.488 | > tsc && vite build
16:56:24.488 |  
16:56:32.623 | src/components/Sidebar/SidebarDesktop.tsx(1,15): error TS2305: Module '"@chakra-ui/react"' has no exported member 'keyframes'.
16:56:32.658 | ELIFECYCLE  Command failed with exit code 2.
16:56:32.690 | Failed: Error while executing user command. Exited with error code: 2
16:56:32.700 | Failed: build command exited with code: 1
16:56:33.704 | Failed: error occurred while running build command

Copy link

cloudflare-workers-and-pages bot commented Oct 8, 2024

Deploying chatcraft-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6ff346a
Status: ✅  Deploy successful!
Preview URL: https://3bde30ed.console-overthinker-dev.pages.dev
Branch Preview URL: https://issue-689.console-overthinker-dev.pages.dev

View logs

@menghif
Copy link
Collaborator Author

menghif commented Oct 8, 2024

Cloudflare build fails like so:


16:56:24.488 | > [email protected] build /opt/buildhome/repo
-- | --
16:56:24.488 | > tsc && vite build
16:56:24.488 |  
16:56:32.623 | src/components/Sidebar/SidebarDesktop.tsx(1,15): error TS2305: Module '"@chakra-ui/react"' has no exported member 'keyframes'.
16:56:32.658 | ELIFECYCLE  Command failed with exit code 2.
16:56:32.690 | Failed: Error while executing user command. Exited with error code: 2
16:56:32.700 | Failed: build command exited with code: 1
16:56:33.704 | Failed: error occurred while running build command

This is because I upgraded @chakra-ui/react without noticing. I reverted it now!

@menghif menghif requested a review from humphd October 8, 2024 00:18
Copy link
Collaborator

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@humphd humphd added the hacktoberfest-accepted PRs done as part of Hacktoberfest label Oct 8, 2024
@humphd humphd merged commit 9646305 into main Oct 8, 2024
4 checks passed
@humphd humphd deleted the issue-689 branch October 8, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs done as part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ESLint and various plugins to v9 ecosystem
2 participants