replicaset: validate name in replicaset_locate_master #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serpentian
force-pushed
the
name-validation-follow-up
branch
from
16afd10 to
4723783
Compare
Gerold103
requested changes
Jan 23, 2024
Serpentian
force-pushed
the
name-validation-follow-up
branch
2 times, most recently
from
c56639f to
2d8178b
Compare
Serpentian
force-pushed
the
name-validation-follow-up
branch
from
2d8178b to
1f1fe44
Compare
Currently, the name validation is not used, when locate_master() is called. It makes an explicit call via the connection to obtain a future object in order to figure out, whether the node is a master. We should not make any calls to a replica until the time, we definitely know, that its name and uuid was validated. Let's use replica_call instead of conn.call. Follow-up tarantool#426 NO_DOC=bugfix
Serpentian
force-pushed
the
name-validation-follow-up
branch
from
1f1fe44 to
a5360e8
Compare
Gerold103
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the name validation is not used, when locate_master() is called. It makes an explicit call via the connection to obtain a future object in order to figure out, whether the node is a master.
We should not make any calls to a replica until the time, we definitely know, that its name and uuid was validated. Let's use replica_call instead of conn.call.
Follow-up #426
NO_DOC=bugfix