Support Tarantool 3.0 `box.info` changes #402

Gerold103 · 2023-03-07T21:33:18Z

In 3.0 the field box.info.cluster is renamed to box.info.replicaset. And there will be a new field box.info.cluster which will not have UUID and will have name field (for the whole cluster name, not for the single replicaset).

vshard.util should expose a function box_info_replicaset(info) which takes a box.info and returns replicaset. In < 3.0 it should return info.cluster. In >= 3.0 it should return info.replicaset. Usage example - uuid = util.box_info_replicaset(box.info).

I intentionally want to pass info as an argument. For cases when box.info is already done outside.

Also need to replace all the existing box.info.cluster usages with this new function.

The text was updated successfully, but these errors were encountered:

The newest Tarantool release will make several breaking changes. The one concerning vshard - box.info.cluster changes its meaning. This patch introduces a function for getting replicaset UUID not depending on core Tarantool version. Worth mentioning that Server:replicaset_uuid() workarounds this issue on its own intentionally, without vshard.util. This is because luatest shouldn't depend on vshard. One test is still failing - upgrade.test.lua. It fails because calls vshard.storage.cfg{} on 3.0 before upgrade. Non-first cfg won't work on 3.0 because it uses box.info.cluster.uuid to check if it matches UUID in the config. This can't be fixed as the old code is already released years ago. The test itself can be fixed, but it needs a commit to checkout to upgrade from it. This commit is the first one supporting 3.0. It means the test can only be fixed as a follow-up commit. Another reload/upgrade test is reload_evolution/storage.test.lua. It still works because doesn't try to call vshard.storage.cfg{} until reload happens. Lets keep it while it is working fine. Closes #402 NO_DOC=bugfix

The test tried to call vshard.storage.cfg{} second time on 3.0 using an old vshard version. It won't work because the old non-first cfg tried to compare box.info.cluster.uuid with the replicaset UUID in the config. But box.info.cluster.uuid is nil in 3.0. It was moved to box.info.replicaset.uuid. The patch makes the upgrade test use the first commit compatible with 3.0 as the basic version, if the Tarantool executable is 3.0. Note that on versions < 3.0 the vshard upgrade still works fine, hence on old executables the basic version is kept as is. Follow up #402 NO_DOC=test

The newest Tarantool release will make several breaking changes. The one concerning vshard - box.info.cluster changes its meaning. This patch introduces a function for getting replicaset UUID not depending on core Tarantool version. Worth mentioning that Server:replicaset_uuid() workarounds this issue on its own intentionally, without vshard.util. This is because luatest shouldn't depend on vshard. One test is still failing - upgrade.test.lua. It fails because calls vshard.storage.cfg{} on 3.0 before upgrade. Non-first cfg won't work on 3.0 because it uses box.info.cluster.uuid to check if it matches UUID in the config. This can't be fixed as the old code is already released years ago. The test itself can be fixed, but it needs a commit to checkout to upgrade from it. This commit is the first one supporting 3.0. It means the test can only be fixed as a follow-up commit. Another reload/upgrade test is reload_evolution/storage.test.lua. It still works because doesn't try to call vshard.storage.cfg{} until reload happens. Lets keep it while it is working fine. Closes #402 NO_DOC=bugfix

The test tried to call vshard.storage.cfg{} second time on 3.0 using an old vshard version. It won't work because the old non-first cfg tried to compare box.info.cluster.uuid with the replicaset UUID in the config. But box.info.cluster.uuid is nil in 3.0. It was moved to box.info.replicaset.uuid. The patch makes the upgrade test use the first commit compatible with 3.0 as the basic version, if the Tarantool executable is 3.0. Note that on versions < 3.0 the vshard upgrade still works fine, hence on old executables the basic version is kept as is. Follow up #402 NO_DOC=test

The newest Tarantool release will make several breaking changes. The one concerning vshard - box.info.cluster changes its meaning. This patch introduces a function for getting replicaset UUID not depending on core Tarantool version. Worth mentioning that Server:replicaset_uuid() workarounds this issue on its own intentionally, without vshard.util. This is because luatest shouldn't depend on vshard. One test is still failing - upgrade.test.lua. It fails because calls vshard.storage.cfg{} on 3.0 before upgrade. Non-first cfg won't work on 3.0 because it uses box.info.cluster.uuid to check if it matches UUID in the config. This can't be fixed as the old code is already released years ago. The test itself can be fixed, but it needs a commit to checkout to upgrade from it. This commit is the first one supporting 3.0. It means the test can only be fixed as a follow-up commit. Another reload/upgrade test is reload_evolution/storage.test.lua. It still works because doesn't try to call vshard.storage.cfg{} until reload happens. Lets keep it while it is working fine. Closes #402 NO_DOC=bugfix

The test tried to call vshard.storage.cfg{} second time on 3.0 using an old vshard version. It won't work because the old non-first cfg tried to compare box.info.cluster.uuid with the replicaset UUID in the config. But box.info.cluster.uuid is nil in 3.0. It was moved to box.info.replicaset.uuid. The patch makes the upgrade test use the first commit compatible with 3.0 as the basic version, if the Tarantool executable is 3.0. Note that on versions < 3.0 the vshard upgrade still works fine, hence on old executables the basic version is kept as is. Follow up #402 NO_DOC=test

The newest Tarantool release will make several breaking changes. The one concerning vshard - box.info.cluster changes its meaning. This patch introduces a function for getting replicaset UUID not depending on core Tarantool version. Worth mentioning that Server:replicaset_uuid() workarounds this issue on its own intentionally, without vshard.util. This is because luatest shouldn't depend on vshard. One test is still failing - upgrade.test.lua. It fails because calls vshard.storage.cfg{} on 3.0 before upgrade. Non-first cfg won't work on 3.0 because it uses box.info.cluster.uuid to check if it matches UUID in the config. This can't be fixed as the old code is already released years ago. The test itself can be fixed, but it needs a commit to checkout to upgrade from it. This commit is the first one supporting 3.0. It means the test can only be fixed as a follow-up commit. Another reload/upgrade test is reload_evolution/storage.test.lua. It still works because doesn't try to call vshard.storage.cfg{} until reload happens. Lets keep it while it is working fine. Closes #402 NO_DOC=bugfix

The test tried to call vshard.storage.cfg{} second time on 3.0 using an old vshard version. It won't work because the old non-first cfg tried to compare box.info.cluster.uuid with the replicaset UUID in the config. But box.info.cluster.uuid is nil in 3.0. It was moved to box.info.replicaset.uuid. The patch makes the upgrade test use the first commit compatible with 3.0 as the basic version, if the Tarantool executable is 3.0. Note that on versions < 3.0 the vshard upgrade still works fine, hence on old executables the basic version is kept as is. Follow up #402 NO_DOC=test

Gerold103 added the feature A new functionality label Mar 7, 2023

Gerold103 self-assigned this Mar 28, 2023

Gerold103 closed this as completed in e5f2cc0 May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Tarantool 3.0 `box.info` changes #402

Support Tarantool 3.0 `box.info` changes #402

Gerold103 commented Mar 7, 2023

Support Tarantool 3.0 box.info changes #402

Support Tarantool 3.0 box.info changes #402

Comments

Gerold103 commented Mar 7, 2023

Support Tarantool 3.0 `box.info` changes #402

Support Tarantool 3.0 `box.info` changes #402