Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aeon: fix repo URL for Aeon submodule #1084

Merged
merged 1 commit into from
Jan 16, 2025
Merged

aeon: fix repo URL for Aeon submodule #1084

merged 1 commit into from
Jan 16, 2025
+1 −1

Conversation

dmyger
Copy link
Collaborator

@dmyger dmyger commented Jan 16, 2025 •
edited
Loading

Use HTTPS instead Git protocol to avoid extra authorization.

@dmyger dmyger changed the title aeon: fix URL for aeon-api-protos submodule ci: fix URL for submodule as relative Jan 16, 2025
@dmyger dmyger force-pushed the dmyger/gh-no_fix_aeon-protos_url branch from 4457ec2 to 9d0349a Compare January 16, 2025 11:31
@dmyger dmyger added the full-ci Enables full ci tests label Jan 16, 2025
oleg-jukovec
oleg-jukovec reviewed Jan 16, 2025
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
Totktonada
Totktonada reviewed Jan 16, 2025
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
@dmyger dmyger requested a review from oleg-jukovec January 16, 2025 11:41
@dmyger dmyger force-pushed the dmyger/gh-no_fix_aeon-protos_url branch 2 times, most recently from 91cd5c3 to 5221611 Compare January 16, 2025 11:46
@dmyger dmyger requested a review from Totktonada January 16, 2025 11:49
Totktonada
Totktonada approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is OK, but I see that a discussion about using relative paths is ongoing. It depends on your plans where to host the repositories and I can't judge here.

oleg-jukovec
oleg-jukovec approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, we can fix relative paths it if something breaks in the future after migration to GitLab.

@dmyger
aeon: fix repo URL for Aeon submodule
9832b01 
Use HTTPS instead Git protocol to avoid extra authorization.
@dmyger dmyger force-pushed the dmyger/gh-no_fix_aeon-protos_url branch from 5221611 to 9832b01 Compare January 16, 2025 17:00
@dmyger dmyger changed the title ci: fix URL for submodule as relative aeon: fix repo URL for Aeon submodule Jan 16, 2025
dmyger
dmyger commented Jan 16, 2025
View reviewed changes
Copy link
Collaborator Author

@dmyger dmyger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to test issues, did the absolute path, just don't spend time to figure out why they don't work.

@oleg-jukovec oleg-jukovec merged commit ac5e2e0 into master Jan 16, 2025
19 of 24 checks passed
@oleg-jukovec oleg-jukovec deleted the dmyger/gh-no_fix_aeon-protos_url branch January 16, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
full-ci Enables full ci tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmyger @Totktonada @oleg-jukovec