Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace tarantool bugs xfail to skip #236

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

DifferentialOrange
Copy link
Member

@DifferentialOrange DifferentialOrange commented Oct 5, 2022

Tests related to Tarantool datetime bugs [1, 2] are marked with xfail so it would be convenient to notice when the bug is fixed. At the same time, tarantool/tarantool CI requires that tarantool/tarantool-python must be green for each PR and it's not work for a PR with datetime bugs [1, 2] fix: xfail triggers "unexpected success" and CI fails. To break this codependency, this patch replaces xfail with skip.

  1. Datetime with timezone subtraction tarantool#7698
  2. Interval ariphmetic with offset change tarantool#7700

Follows #229

Tests related to Tarantool datetime bugs [1, 2] are marked with xfail
so it would be convenient to notice when the bug is fixed.
At the same time, tarantool/tarantool CI requires that
tarantool/tarantool-python CI must be green for each PR and it's not
work for a PR with datetime bugs [1, 2] fix: xfail triggers "unexpected
success" and CI fails. To break this codependency, this patch replaces
xfail with skip.

1. tarantool/tarantool#7698
2.tarantool/tarantool#7700

Follows #229
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-229-xfail-to-skip branch from 420030f to d35b2ce Compare October 5, 2022 15:42
@DifferentialOrange DifferentialOrange merged commit 5ffe902 into master Oct 5, 2022
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/gh-229-xfail-to-skip branch October 5, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant