Support datetime extended type #228

DifferentialOrange · 2022-08-31T16:20:41Z

msgpack: support datetime extended type

Tarantool supports datetime type since version 2.10.0 [1]. This patch introduced the support of Tarantool datetime type in msgpack decoders and encoders.

Tarantool datetime objects are decoded to tarantool.Datetime type. tarantool.Datetime may be encoded to Tarantool datetime objects.

tarantool.Datetime stores data in a pandas.Timestamp object. You can create tarantool.Datetime objects either from msgpack data or by using the same API as in Tarantool:

dt1 = tarantool.Datetime(year=2022, month=8, day=31,
                         hour=18, minute=7, sec=54,
                         nsec=308543321)

dt2 = tarantool.Datetime(timestamp=1661969274)

dt3 = tarantool.Datetime(timestamp=1661969274, nsec=308543321)

tarantool.Datetime exposes year, month, day, hour, minute, sec, nsec and timestamp properties if you need to convert tarantool.Datetime to any other kind of datetime object:

pdt = pandas.Timestamp(year=dt.year, month=dt.month, day=dt.day,
                       hour=dt.hour, minute=dt.minute, second=dt.sec,
                       microsecond=(dt.nsec // 1000),
                       nanosecond=(dt.nsec % 1000))

pandas.Timestamp was chosen to store data because it could be used to store both nanoseconds and timezone information. In-build Python datetime.datetime supports microseconds at most, numpy.datetime64 do not support timezones.

Tarantool datetime interval type is planned to be stored in custom type tarantool.Interval and we'll need a way to support arithmetic between datetime and interval. This is the main reason we use custom class instead of plain pandas.Timestamp. It is also hard to implement Tarantool-compatible timezones with full conversion support without custom classes.

This patch does not yet introduce the support of timezones in datetime.

Part of #204

msgpack: support tzoffset in datetime

Support non-zero tzoffset in datetime extended type.

Use tzoffset parameter to set up offset timezone:

dt = tarantool.Datetime(year=2022, month=8, day=31,
                        hour=18, minute=7, sec=54,
                        nsec=308543321, tzoffset=180)

You may use tzoffset property to get timezone offset of a datetime object.

Offset timezone is built with pytz.FixedOffset(). pytz module is already a dependency of pandas, but this patch adds it as a requirement just in case something will change in the future.

This patch doesn't yet introduce the support of named timezones (tzindex).

Part of #204

msgpack: support tzindex in datetime

Support non-zero tzindex in datetime extended type. If both tzoffset and tzindex are specified, tzindex is prior (same as in Tarantool [1]).

Use tz parameter to set up timezone name:

dt = tarantool.Datetime(year=2022, month=8, day=31,
                        hour=18, minute=7, sec=54,
                        nsec=308543321, tz='Europe/Moscow')

You may use tz property to get timezone name of a datetime object.

pytz is used to build timezone info. Tarantool index to Olson name map and inverted one are built with gen_timezones.sh script based on tarantool/go-tarantool script [2]. All Tarantool unique and alias timezones presents in pytz.all_timezones list. Only the following abbreviated timezones from Tarantool presents in pytz.all_timezones (version 2022.2.1):

CET
EET
EST
GMT
HST
MST
UTC
WET

pytz does not natively support work with abbreviated timezones due to its possibly ambiguous nature [3-5]. Tarantool itself do not support work with ambiguous abbreviated timezones:

Tarantool 2.10.1-0-g482d91c66

tarantool> datetime.new({tz = 'BST'})
---
- error: 'builtin/datetime.lua:477: could not parse ''BST'' - ambiguous timezone'
...

If ambiguous timezone is specified, the exception is raised.

Tarantool header timezones.h [6] provides a map for all abbreviated timezones with category info (all ambiguous timezones are marked with TZ_AMBIGUOUS flag) and offset info. We parse this info to build pytz.FixedOffset() timezone for each Tarantool abbreviated timezone not supported natively by pytz.

Closes #204

DifferentialOrange · 2022-09-08T12:41:00Z

Class inheritance should be improved before review.

>>> dt = tarantool.Datetime(year = 1970, month = 1, day = 2)
>>> dt
Timestamp('1970-01-02 00:00:00')
>>> type(dt)
<class 'tarantool.msgpack_ext.types.datetime.Datetime'>
>>> dt.floor('H')
Timestamp('1970-01-02 00:00:00')
>>> type(dt.floor('H'))
<class 'pandas._libs.tslibs.timestamps.Timestamp'>

DifferentialOrange · 2022-09-13T10:08:11Z

@oleg-jukovec , thank you for pointing out about custom timezones. Now we encode abbreviated timezones to datetime.timezone with expected offset and Tarantool name. Decode for them is also supported.

If user wants to create a tarantool.Datetime with Tarantool abbreviated timezone, he may build the custom timezone based on our autogenerated timezones info:

import tarantool.msgpack_ext.types.timezones as tt_timezones

tzinfo = datetime.timezone(
    datetime.timedelta(minutes=tt_timezones.timezoneAbbrevInfo['MSK']['offset']),
    name='MSK'
)

dt = tarantool.Datetime(
    year=2022, month=8, day=31, hour=18, minute=7, second=54,
    microsecond=308543, nanosecond=321, tzinfo=tzinfo
)

I'm not sure we should expose tt_timezones.timezoneAbbrevInfo to a main tarantool module, but this is debatable.

CHANGELOG.md

tarantool/msgpack_ext/types/datetime.py

test/suites/test_datetime.py

tarantool/msgpack_ext/types/datetime.py

DifferentialOrange · 2022-09-15T13:13:53Z

Timezones in tarantool-python RFC

Tarantool datetime may provide timezone info in two forms: tzoffset and tzindex.

It corresponds to Lua datetime.new{} tzoffset and tz arguments. tz string is mapped to a tzindex based on timezones.h header.

Based on Lua API, user can set up only tz (same as tzindex) or tzoffset. If tz (same as tzindex) is set up, tzoffset is computed based on tz info. Both tzindex and tzoffset is provided to msgpack data if tzindex is set up, but tzoffset is expected to be based on tzindex info: see tarantool/tarantool#7680.

What should we use to store timezone info? The solution should satisfy several criteria:

we should be able to unambiguously be able to reencode it,
it should be useful.

Let's discuss both of them.

We should unambiguously be able to encode it to the same msgpack, i.e. the same tzindex, tzoffset info. Actually, it's more tricky: not all timezones are fixed offset. For example, tzoffset for 'Europe/Moscow' timezone is 180 for 1.1.2008 and 240 for 1.7.2008. So what we actually want is to be able to preserve tzindex and to have tzoffset the same
as it would be in Tarantool for same timestamp + tz (and this is really important, see tarantool/tarantool#7680 again).

What does it mean that it should be useful? It should be not just a reference info, but a real timezone. If user would want to do something with datetime info, it should behave appropriately. Again, for example, if user gets 1.1.2008 with 'Europe/Moscow' and then adds half a year with some default method, it should be 1.7.2008 with 'Europe/Moscow' considering winter time. It is also important since we encode timestamp values based on time since 1.1.1970 UTC and it depends on thing like winter time.

There is a pytz library (already a dependency of pandas) that implements Olson database that tarantool uses to compute tzoffset for named timezones. We may use pytz library to work with timezone info. All of Tarantool ZONE_UNIQUEs and ZONE_ALIASes are supported by pytz. Tarantool also has ZONE_ABBREVs: timezones with name and fixed offset. pytz doesn't know about most of them, but it is easy to implement them manually with pytz.FixedOffset or datetime.timezone(datetime.timedelta) based on timezones.h header offset info.

It is rather inconvenient to store tzindex (or tz name) with some existing pytz or datetime tools. For example, we need to distinct fixed offset timezones with name and without a name. You can set up a name for datetime.timezone(datetime.timedelta),
but it could be retrieved only with tz.tzname(dt) call. datetime.timezone generates the name on tzname call and there is no non-intrusive way to distinct autogenerated name from explicitly set up name. pytz.FixedOffset could not have any name at all
(expect for pytz.FixedOffset(0) which is actually UTC). So it looks like the only way is

to decode tarantool timezones to custom tarantool.Timezone type.

Since we already use pytz.timezone, let's use pytz.FixedOffset as a base class for fixed timezone data.

This type should be useful, so it should implement standard datetime.tzinfo interface (utcoffset, tzname and dst). It would simply expose utcoffset, tzname and dst methods of timezone data underneath class. With some additional handles, it would expose tzindex (or tarantool tz name) and the copy of underneath class (just in case).

tarantool.Datetime supports building from pandas.Timestamp or with tzinfo argument. tzinfo argument or pandas.Timestamp.tzinfo may be not a tarantool.Timezone. Using only tarantool.Timezone in tarantool.Datetime is a way to ensure that everything would be symmetrical on encode/decode.
So there are two possible ways:

do not accept any timezones other that tarantool.Timezone,
convert other timezones to tarantool.Timezone.

If we won't be able to accept any other timezones, it would be an another burden on user's shoulders. To impove his experience, we may provide some migration advices.

On the other hand, converting may be provided not as expected by user. Since

there is always a way to provide an explicitly converted value,
migration advices is some code that could be easily implemented from our side,
I prefer to support converting other timezones to tarantool.Timezone on tarantool.Datetime initialization.
To ensure our safety, we will strictly recommend user to use tarantool.Timezone with warnings, warning message would contain info about how exactly we had converted tzinfo, so user could always check if his expectations is the same as what we do.

Let's describe converting rules. If tzinfo is a pytz base class (pytz.tzinfo.BaseTzInfo), we check its .zone attribute,
and if it is not None, we use it as timezone name. In result, tarantool.Datetime(name=zone) and pytz.timezone(zone) would have the same zone underneath.

If tzinfo is not a pytz base class, we call tz.tzname(dt), defined by interface, to get a timezone name. For example, pytz._FixedOffset (it is not an instance of pytz.tzinfo.BaseTzInfo) has None name. We not use tz.tzname(dt) for pytz base class because it's output is frustrating. For example, tz.tzname(dt) for pytz.timezone('Europe/Moscow') is either MSK
or MSD, and tarantool.Datetime(name='Europe/Moscow') and tarantool.Datetime(name='MSK')
are different timezones.

If timezone has a name that is unknown to Tarantool, we raise an error. If timezone has None name, we treat it as fixed offset zone.

We would not implement tzindex/tzoffset correspondence checkup. We will wait for tarantool/tarantool#7680 updates.

DifferentialOrange · 2022-09-16T10:26:05Z

to decode tarantool timezones to custom tarantool.Timezone type.

Well, actually, you simply can't do it. pandas cannot work with any datetime.tzinfo instance -- it could work only with pytz or dateutil timezones.

pandas-dev/pandas#15986 (comment)
python-pendulum/pendulum#131

pandas source code is full of workaround to detect if it is pytz timezone and mess with its internals.

DifferentialOrange · 2022-09-19T15:28:10Z

After discussion with @oleg-jukovec , we decided to implement tarantool.Datetime API to be the same as in tarantool Lua datetime module. You can build datetime from msgpack payload or with the same API as in Tarantool. Object expose all properties required to convert it to any other datetime (year, month, day, hour, minute, sec, nsec, timestamp, tzoffset, tz -- names are the same except for minute instead of min since it is a keyword in Python) but do not support in-built convertions to pandas or do not expose internal pandas.Timestamp or pytz timezone to simplify the behavior.

DifferentialOrange · 2022-09-19T15:29:16Z

@oleg-jukovec , @LeonidVas , new revision had been uploaded, humbly requesting one more review iteration.

oleg-jukovec

Thanks for the changes. I think this is a clearer solution than previous.

tarantool/msgpack_ext/types/datetime.py

oleg-jukovec · 2022-09-20T09:48:05Z

tarantool/msgpack_ext/types/datetime.py

+    def msgpack_encode(self):
+        seconds = self._datetime.value // NSEC_IN_SEC
+        nsec = self.nsec
+        tzoffset = self.tzoffset
+
+        tz = self.tz
+        if tz != '':
+            tzindex = tt_timezones.timezoneToIndex[tz]
+        else:
+            tzindex = 0
+
+        buf = get_int_as_bytes(seconds, SECONDS_SIZE_BYTES)
+
+        if (nsec != 0) or (tzoffset != 0) or (tzindex != 0):
+            buf = buf + get_int_as_bytes(nsec, NSEC_SIZE_BYTES)
+            buf = buf + get_int_as_bytes(tzoffset, TZOFFSET_SIZE_BYTES)
+            buf = buf + get_int_as_bytes(tzindex, TZINDEX_SIZE_BYTES)
+
+        return buf


I think it's better to do decoding as a separate function, rather than a class method.

Up to you.

Well, since it works with class internals (like self._datetime.value), it better be a part of the class. And I'm not so sure value should be exposed as a property.

Is it not true self._datetime.value // NSEC_IN_SEC == Int(self.timestamp) ?

Well, until there is no precision loss on conversion from float to int.

https://github.com/pandas-dev/pandas/blob/6dc589b957e494750351e8572b45b8fa12c27d01/pandas/_libs/tslibs/timestamps.pyx#L1139-L1154

What about long(self.timestamp) ?

Well, I think we may say that the main responsibility of Datetime is to be encoded and decoded.

And decoding is already a class method (as an __init__ constructor).

Well, I think we may say that the main responsibility of Datetime is to be encoded and decoded.

At this stage the class looks like DTO and serialization/deserialization methods is ok. But I guess (I did not look at an inteval pull request) that AddInterval/SubInterval/SubDatetime methods will be added in the future. After that, this class will no longer look like a DTO and serialization/deserialization methos will look strange.

In fact, the class does not require the decode method in the current implementation. There is no need for it.

AddInterval/SubInterval/SubDatetime

They are implemented as operators overload.

In fact, the class does not require the decode method in the current implementation.

Well, I wouldn't be too sure about this. For example, if decode would be external, it would be bad for performance because we would need to create excessive intermediate pandas.Timestamp to transform epoch to year/month/day/etc. Moreover, as far as I remember, pandas and Tarantool treat epoch + tz with different approaches (and that's the reason decode do .replace(tzinfo=pytz.UTC).tz_convert(tzinfo) and __init__ do .replace(tzinfo=tzinfo)), so may need to add some workarounds.

CHANGELOG.md

tarantool/msgpack_ext/types/datetime.py

DifferentialOrange · 2022-09-20T11:28:52Z

I think this is a clearer solution than previous.

Yeah, it definitely is. Thank you for your advises, the last version of my implementation was dissatisfying for myself too.

oleg-jukovec

LGTM

Tarantool supports datetime type since version 2.10.0 [1]. This patch introduced the support of Tarantool datetime type in msgpack decoders and encoders. Tarantool datetime objects are decoded to `tarantool.Datetime` type. `tarantool.Datetime` may be encoded to Tarantool datetime objects. `tarantool.Datetime` stores data in a `pandas.Timestamp` object. You can create `tarantool.Datetime` objects either from msgpack data or by using the same API as in Tarantool: ``` dt1 = tarantool.Datetime(year=2022, month=8, day=31, hour=18, minute=7, sec=54, nsec=308543321) dt2 = tarantool.Datetime(timestamp=1661969274) dt3 = tarantool.Datetime(timestamp=1661969274, nsec=308543321) ``` `tarantool.Datetime` exposes `year`, `month`, `day`, `hour`, `minute`, `sec`, `nsec`, `timestamp` and `value` (integer epoch time with nanoseconds precision) properties if you need to convert `tarantool.Datetime` to any other kind of datetime object: ``` pdt = pandas.Timestamp(year=dt.year, month=dt.month, day=dt.day, hour=dt.hour, minute=dt.minute, second=dt.sec, microsecond=(dt.nsec // 1000), nanosecond=(dt.nsec % 1000)) ``` `pandas.Timestamp` was chosen to store data because it could be used to store both nanoseconds and timezone information. In-build Python `datetime.datetime` supports microseconds at most, `numpy.datetime64` do not support timezones. Tarantool datetime interval type is planned to be stored in custom type `tarantool.Interval` and we'll need a way to support arithmetic between datetime and interval. This is the main reason we use custom class instead of plain `pandas.Timestamp`. It is also hard to implement Tarantool-compatible timezones with full conversion support without custom classes. This patch does not yet introduce the support of timezones in datetime. 1. tarantool/tarantool#5941 2. https://pandas.pydata.org/docs/reference/api/pandas.Timestamp.html Part of #204

Support non-zero tzoffset in datetime extended type. Use `tzoffset` parameter to set up offset timezone: ``` dt = tarantool.Datetime(year=2022, month=8, day=31, hour=18, minute=7, sec=54, nsec=308543321, tzoffset=180) ``` You may use `tzoffset` property to get timezone offset of a datetime object. Offset timezone is built with pytz.FixedOffset(). pytz module is already a dependency of pandas, but this patch adds it as a requirement just in case something will change in the future. This patch doesn't yet introduce the support of named timezones (tzindex). Part of #204

Support non-zero tzindex in datetime extended type. If both tzoffset and tzindex are specified, tzindex is prior (same as in Tarantool [1]). Use `tz` parameter to set up timezone name: ``` dt = tarantool.Datetime(year=2022, month=8, day=31, hour=18, minute=7, sec=54, nsec=308543321, tz='Europe/Moscow') ``` You may use `tz` property to get timezone name of a datetime object. pytz is used to build timezone info. Tarantool index to Olson name map and inverted one are built with gen_timezones.sh script based on tarantool/go-tarantool script [2]. All Tarantool unique and alias timezones present in pytz.all_timezones list. Only the following abbreviated timezones from Tarantool presents in pytz.all_timezones (version 2022.2.1): - CET - EET - EST - GMT - HST - MST - UTC - WET pytz does not natively support work with abbreviated timezones due to its possibly ambiguous nature [3-5]. Tarantool itself do not support work with ambiguous abbreviated timezones: ``` Tarantool 2.10.1-0-g482d91c66 tarantool> datetime.new({tz = 'BST'}) --- - error: 'builtin/datetime.lua:477: could not parse ''BST'' - ambiguous timezone' ... ``` If ambiguous timezone is specified, the exception is raised. Tarantool header timezones.h [6] provides a map for all abbreviated timezones with category info (all ambiguous timezones are marked with TZ_AMBIGUOUS flag) and offset info. We parse this info to build pytz.FixedOffset() timezone for each Tarantool abbreviated timezone not supported natively by pytz. 1. https://www.tarantool.io/en/doc/latest/reference/reference_lua/datetime/new/ 2. https://github.com/tarantool/go-tarantool/blob/5801dc6f5ce69db7c8bc0c0d0fe4fb6042d5ecbc/datetime/gen-timezones.sh 3. https://stackoverflow.com/questions/37109945/how-to-use-abbreviated-timezone-namepst-ist-in-pytz 4. https://stackoverflow.com/questions/27531718/datetime-timezone-conversion-using-pytz 5. https://stackoverflow.com/questions/30315485/pytz-return-olson-timezone-name-from-only-a-gmt-offset 6. https://github.com/tarantool/tarantool/9ee45289e01232b8df1413efea11db170ae3b3b4/src/lib/tzcode/timezones.h Closes #204

DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch 2 times, most recently from 1e57e7b to 747995c Compare September 1, 2022 10:28

DifferentialOrange mentioned this pull request Sep 1, 2022

Support decimal extended type #226

Merged

DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch 2 times, most recently from df7f4f9 to 3ac6206 Compare September 2, 2022 06:54

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch 4 times, most recently from c1cf8b4 to 0bee71e Compare September 5, 2022 09:47

DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch from 3ac6206 to 989af6c Compare September 5, 2022 13:46

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch 5 times, most recently from cf4ed18 to 57491fc Compare September 7, 2022 10:20

DifferentialOrange changed the title ~~Differential orange/gh 204 datetime~~ Support datetime extended type Sep 7, 2022

DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch 2 times, most recently from 7181eb0 to 51ece90 Compare September 7, 2022 12:03

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch from 57491fc to e7aab2b Compare September 7, 2022 12:20

Base automatically changed from DifferentialOrange/gh-202-uuid to master September 7, 2022 12:21

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch 2 times, most recently from 76b526b to 7d847c8 Compare September 7, 2022 12:39

DifferentialOrange marked this pull request as ready for review September 7, 2022 12:49

DifferentialOrange requested a review from oleg-jukovec September 7, 2022 12:51

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch 2 times, most recently from b0d1b7e to 8b25d9d Compare September 7, 2022 13:00

DifferentialOrange removed the request for review from oleg-jukovec September 8, 2022 12:40

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch 2 times, most recently from 8234495 to d9b6748 Compare September 8, 2022 16:21

DifferentialOrange requested a review from oleg-jukovec September 13, 2022 10:09

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch 2 times, most recently from 2f7f662 to fc77b4c Compare September 13, 2022 10:20

oleg-jukovec reviewed Sep 13, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

tarantool/msgpack_ext/types/datetime.py Outdated Show resolved Hide resolved

tarantool/msgpack_ext/types/datetime.py Outdated Show resolved Hide resolved

tarantool/msgpack_ext/types/datetime.py Outdated Show resolved Hide resolved

oleg-jukovec requested changes Sep 13, 2022

View reviewed changes

tarantool/msgpack_ext/types/datetime.py Outdated Show resolved Hide resolved

test/suites/test_datetime.py Show resolved Hide resolved

oleg-jukovec reviewed Sep 13, 2022

View reviewed changes

tarantool/msgpack_ext/types/datetime.py Outdated Show resolved Hide resolved

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch 2 times, most recently from 3f02566 to c8ae392 Compare September 14, 2022 07:04

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch 2 times, most recently from 2dc6c75 to f95056a Compare September 19, 2022 15:22

DifferentialOrange requested review from oleg-jukovec and LeonidVas September 19, 2022 15:29

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch 2 times, most recently from d4e0aed to 47d9864 Compare September 19, 2022 15:32

oleg-jukovec reviewed Sep 20, 2022

View reviewed changes

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch from 47d9864 to e71a4ac Compare September 20, 2022 11:25

oleg-jukovec approved these changes Sep 21, 2022

View reviewed changes

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch from e71a4ac to 8c92b86 Compare September 22, 2022 07:48

DifferentialOrange added 3 commits September 26, 2022 09:31

DifferentialOrange force-pushed the DifferentialOrange/gh-204-datetime branch from 8c92b86 to aa7302a Compare September 26, 2022 06:52

DifferentialOrange merged commit 976a990 into master Sep 26, 2022

DifferentialOrange deleted the DifferentialOrange/gh-204-datetime branch September 26, 2022 07:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support datetime extended type #228

Support datetime extended type #228

DifferentialOrange commented Aug 31, 2022 •

edited

Loading

DifferentialOrange commented Sep 8, 2022

DifferentialOrange commented Sep 13, 2022 •

edited

Loading

DifferentialOrange commented Sep 15, 2022

DifferentialOrange commented Sep 16, 2022 •

edited

Loading

DifferentialOrange commented Sep 19, 2022

DifferentialOrange commented Sep 19, 2022

oleg-jukovec left a comment

oleg-jukovec Sep 20, 2022

DifferentialOrange Sep 20, 2022 •

edited

Loading

oleg-jukovec Sep 21, 2022

DifferentialOrange Sep 21, 2022

oleg-jukovec Sep 21, 2022 •

edited

Loading

DifferentialOrange Sep 22, 2022

DifferentialOrange Sep 22, 2022 •

edited

Loading

oleg-jukovec Sep 22, 2022

DifferentialOrange Sep 22, 2022 •

edited

Loading

DifferentialOrange Sep 22, 2022 •

edited

Loading

DifferentialOrange commented Sep 20, 2022

oleg-jukovec left a comment

Support datetime extended type #228

Support datetime extended type #228

Conversation

DifferentialOrange commented Aug 31, 2022 • edited Loading

msgpack: support datetime extended type

msgpack: support tzoffset in datetime

msgpack: support tzindex in datetime

DifferentialOrange commented Sep 8, 2022

DifferentialOrange commented Sep 13, 2022 • edited Loading

DifferentialOrange commented Sep 15, 2022

Timezones in tarantool-python RFC

DifferentialOrange commented Sep 16, 2022 • edited Loading

DifferentialOrange commented Sep 19, 2022

DifferentialOrange commented Sep 19, 2022

oleg-jukovec left a comment

Choose a reason for hiding this comment

oleg-jukovec Sep 20, 2022

Choose a reason for hiding this comment

DifferentialOrange Sep 20, 2022 • edited Loading

Choose a reason for hiding this comment

oleg-jukovec Sep 21, 2022

Choose a reason for hiding this comment

DifferentialOrange Sep 21, 2022

Choose a reason for hiding this comment

oleg-jukovec Sep 21, 2022 • edited Loading

Choose a reason for hiding this comment

DifferentialOrange Sep 22, 2022

Choose a reason for hiding this comment

DifferentialOrange Sep 22, 2022 • edited Loading

Choose a reason for hiding this comment

oleg-jukovec Sep 22, 2022

Choose a reason for hiding this comment

DifferentialOrange Sep 22, 2022 • edited Loading

Choose a reason for hiding this comment

DifferentialOrange Sep 22, 2022 • edited Loading

Choose a reason for hiding this comment

DifferentialOrange commented Sep 20, 2022

oleg-jukovec left a comment

Choose a reason for hiding this comment

DifferentialOrange commented Aug 31, 2022 •

edited

Loading

DifferentialOrange commented Sep 13, 2022 •

edited

Loading

DifferentialOrange commented Sep 16, 2022 •

edited

Loading

DifferentialOrange Sep 20, 2022 •

edited

Loading

oleg-jukovec Sep 21, 2022 •

edited

Loading

DifferentialOrange Sep 22, 2022 •

edited

Loading

DifferentialOrange Sep 22, 2022 •

edited

Loading

DifferentialOrange Sep 22, 2022 •

edited

Loading