Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: make luaL_pushnull() non-static #76

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Gumix
Copy link
Contributor

@Gumix Gumix commented Jul 11, 2024

Tarantool will make this method public in:
tarantool/tarantool@878c0d0

This patch fixes compilation error:

./mysql/driver.c:53:1: error: static declaration of ‘luaL_pushnull’ follows non-static declaration
   53 | luaL_pushnull(struct lua_State *L)
      | ^~~~~~~~~~~~~

Tarantool will make this method public in:
tarantool/tarantool@878c0d0

This patch fixes compilation error:

./mysql/driver.c:53:1: error: static declaration of ‘luaL_pushnull’ follows non-static declaration
   53 | luaL_pushnull(struct lua_State *L)
      | ^~~~~~~~~~~~~
Copy link
Member

@DifferentialOrange DifferentialOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean it will be impossible to build (or use?) with older Tarantools?

@Gumix
Copy link
Contributor Author

Gumix commented Jul 12, 2024

Does that mean it will be impossible to build (or use?) with older Tarantools?

No, it should work with all versions of Tarantool (with/without tarantool/tarantool@878c0d0).

@DifferentialOrange DifferentialOrange merged commit 154fa91 into master Jul 12, 2024
3 checks passed
@DifferentialOrange DifferentialOrange deleted the fix-luaL_pushnull branch July 12, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants