Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new metrics #483

Merged
merged 8 commits into from
Apr 27, 2024
Merged

Add new metrics #483

merged 8 commits into from
Apr 27, 2024

Conversation

yngvar-antonsson
Copy link
Collaborator

@yngvar-antonsson yngvar-antonsson commented Apr 18, 2024

Adds new metrics, introduced in Tarantool 3.0:

tarantool/tarantool#9059
tarantool/tarantool#8501

I didn't forget about

  • Changelog
  • Documentation (README and rst)

Copy link
Member

@DifferentialOrange DifferentialOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have some basic tests (metrics is set for a proper version and non-zero is there is some data).

metrics/tarantool/memtx.lua Outdated Show resolved Hide resolved
metrics/tarantool/memtx.lua Show resolved Hide resolved
metrics/tarantool/memtx.lua Outdated Show resolved Hide resolved
@yngvar-antonsson yngvar-antonsson merged commit f3eadc1 into master Apr 27, 2024
64 of 69 checks passed
@yngvar-antonsson yngvar-antonsson deleted the add-new-metrics branch April 27, 2024 15:25
DifferentialOrange added a commit to DifferentialOrange/tarantool that referenced this pull request Jul 10, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#482
2. tarantool/metrics#483
3. tarantool/metrics#484
4. tarantool/metrics#491

NO_DOC=doc is a part of submodule
DifferentialOrange added a commit to DifferentialOrange/tarantool that referenced this pull request Jul 10, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#482
2. tarantool/metrics#483
3. tarantool/metrics#484
4. tarantool/metrics#491

NO_DOC=doc is a part of submodule
DifferentialOrange added a commit to DifferentialOrange/tarantool that referenced this pull request Jul 16, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#482
2. tarantool/metrics#483
3. tarantool/metrics#484
4. tarantool/metrics#491

NO_DOC=doc is a part of submodule
Totktonada pushed a commit to tarantool/tarantool that referenced this pull request Jul 22, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#482
2. tarantool/metrics#483
3. tarantool/metrics#484
4. tarantool/metrics#491

NO_DOC=doc is a part of submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants