-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new metrics #483
Merged
Merged
Add new metrics #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have some basic tests (metrics is set for a proper version and non-zero is there is some data).
yngvar-antonsson
force-pushed
the
add-new-metrics
branch
from
April 23, 2024 12:10
a63967d
to
4345bdb
Compare
yngvar-antonsson
force-pushed
the
add-new-metrics
branch
from
April 27, 2024 12:57
77f589a
to
4d4a15e
Compare
Co-authored-by: Georgy Moiseev <[email protected]>
DifferentialOrange
approved these changes
Apr 27, 2024
DifferentialOrange
added a commit
to DifferentialOrange/tarantool
that referenced
this pull request
Jul 10, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect Tarantool, the other ones are related to module infrastructure. 1. tarantool/metrics#482 2. tarantool/metrics#483 3. tarantool/metrics#484 4. tarantool/metrics#491 NO_DOC=doc is a part of submodule
DifferentialOrange
added a commit
to DifferentialOrange/tarantool
that referenced
this pull request
Jul 10, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect Tarantool, the other ones are related to module infrastructure. 1. tarantool/metrics#482 2. tarantool/metrics#483 3. tarantool/metrics#484 4. tarantool/metrics#491 NO_DOC=doc is a part of submodule
DifferentialOrange
added a commit
to DifferentialOrange/tarantool
that referenced
this pull request
Jul 16, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect Tarantool, the other ones are related to module infrastructure. 1. tarantool/metrics#482 2. tarantool/metrics#483 3. tarantool/metrics#484 4. tarantool/metrics#491 NO_DOC=doc is a part of submodule
Totktonada
pushed a commit
to tarantool/tarantool
that referenced
this pull request
Jul 22, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect Tarantool, the other ones are related to module infrastructure. 1. tarantool/metrics#482 2. tarantool/metrics#483 3. tarantool/metrics#484 4. tarantool/metrics#491 NO_DOC=doc is a part of submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new metrics, introduced in Tarantool 3.0:
tarantool/tarantool#9059
tarantool/tarantool#8501
I didn't forget about