api: new export format #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/new-export-format
branch
from
2c25cc0 to
b2f41ee
Compare
github-actions
bot
temporarily deployed
to
translation-new-export-format
github-actions
bot
temporarily deployed
to
translation-new-export-format
DifferentialOrange
force-pushed
the
DifferentialOrange/new-export-format
branch
from
b2f41ee to
97c29d8
Compare
github-actions
bot
temporarily deployed
to
translation-new-export-format
github-actions
bot
temporarily deployed
to
translation-new-export-format
DifferentialOrange
force-pushed
the
DifferentialOrange/new-export-format
branch
from
cfcc861 to
80db8c6
Compare
github-actions
bot
temporarily deployed
to
translation-new-export-format
4 tasks
DifferentialOrange
force-pushed
the
DifferentialOrange/metrics-cfg
branch
from
929f457 to
d892e7d
Compare
Deprecate using control characters (including tabulation) in collector kind, name, observation and global labels. Using such symbols may result in registry collision (some observations may be lost), as well as corrupted plugin output. Part of #435, part of tarantool/tarantool#7725
Collector name prefixes may be used to build names for metric derivatives (average, min, max etc.). For now the rule is as follows: name prefix is the name stripped from the "_total" and "_current" suffixes. (If they presents together at the same time, the name is already messed up, so we don't cover this.) Part of tarantool/tarantool#7725 Part of tarantool/tarantool#7728
Support exhaustive output format for shared-based, counter and gauge collectors collect. It could later be used for export and aggregating without using any other sources of information, (like collectors data, as it used now in Prometheus export). Part of tarantool/tarantool#7725 Part of tarantool/tarantool#7728
Support exhaustive output format for histogram collect. Observations are grouped into sum, count and bucket observations. sum and count observations use the same set of keys. It could later be used for export and aggregating without using any other sources of information, (like collectors data, as it used now in Prometheus export). Part of tarantool/tarantool#7725 Part of tarantool/tarantool#7728
Support exhaustive output format for summary collect. Observations are grouped into sum, count and bucket observations. sum and count observations use the same set of keys. It could later be used for export and aggregating without using any other sources of information, (like collectors data, as it used now in Prometheus export). Part of tarantool/tarantool#7725 Part of tarantool/tarantool#7728
Support exhaustive output format for metrics.collect(). It could later be used for export and aggregating without using any other sources of information (like collectors data, as it used now in Prometheus export). Part of tarantool/tarantool#7725 Part of tarantool/tarantool#7728
After this patch, prometheus export plugin is based on
metrics.collect{invoke_callbacks = true, extended_format = true} result.
Collectors registry info is not required anymore.
Process API is also separated, so now a developer can reuse export
handles if they already have an output (for example, processing
historical data in Flight Recorder).
Older version was preserved for test purposes to ensure that output is
the same in new implementation.
Part of tarantool/tarantool#7725
Part of tarantool/tarantool#7728
After this patch, json export plugin is based on
metrics.collect{invoke_callbacks = true, extended_format = true} result.
Process API is also separated, so now a developer can reuse export
handles if they already have an output (for example, processing
historical data in Flight Recorder).
Older version was preserved for test purposes to ensure that output is
the same in new implementation.
Part of tarantool/tarantool#7725
Part of tarantool/tarantool#7728
After this patch, graphite export plugin is based on
metrics.collect{invoke_callbacks = true, extended_format = true} result.
Process API is also separated, so now a developer can reuse export
handles if he already has an output (for example, processing historical
data in Flight Recorder).
Older version was preserved for test purposes to ensure that output is
the same in new implementation.
Part of tarantool/tarantool#7725
Part of tarantool/tarantool#7728
Advice users to iterate through extensive
metrics.collect{extended_format = true} output instead of collectors.
Part of tarantool/tarantool#7725
Part of tarantool/tarantool#7728
DifferentialOrange
force-pushed
the
DifferentialOrange/new-export-format
branch
from
80db8c6 to
cc08eec
Compare
github-actions
bot
temporarily deployed
to
translation-new-export-format
github-actions
bot
temporarily deployed
to
translation-new-export-format
DifferentialOrange
force-pushed
the
DifferentialOrange/new-export-format
branch
from
545617f to
cc08eec
Compare
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days |
|
Closed in favor of https://github.com/tarantool/roadmap-internal/issues/217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new exhaustive export format on collect. It contains structured info on collectors which may be used on export and aggregation build. (Current
metrics.collect()result is not enough on Prometheus export.metrics.collect{extended_format = true}is enough.) After this PR, export plugins will be based on extended format info.See commit messages for more detailed info.
I didn't forget about
Part of tarantool/tarantool#7725
Part of tarantool/tarantool#7728