Tarantool Feedback Daemon exporter #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/lua-exporter
branch
from
002c114 to
458514e
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/lua-exporter
branch
from
79fa295 to
391be2d
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/lua-exporter
branch
from
380acfb to
948fd7e
Compare
yngvar-antonsson
approved these changes
Jan 26, 2023
Before this patch, any user that wanted to export metrics to their Lua code needed to perform a consecutive call of `metrics.invoke_callbacks` and `metrics.collect`. Now it could be done with a single `collect` call with `invoke_callbacks` option set to `true`. Part of tarantool/tarantool#8192, part of tarantool/tarantool#7725
Allow to add arbitrary table metainfo for collectors. Set to empty table by default. Part of tarantool/tarantool#8192, part of tarantool/tarantool#7725
Set metainfo `default` field to `true` for all metric collectors, created with `enable_default_metrics()` callbacks and psutils `update()` callback. For now, default HTTP middleware collector does not have `default = true` metainfo, but it can be changed later. It is not prohibited for user to set `default` metainfo for their custom metrics. Part of tarantool/tarantool#8192, part of tarantool/tarantool#7725
After this patch, it is possible to collect only default metrics in Lua. Collector metainfo is used to decide which metric is default and which is not. Beware that collect does not control the list of enabled metrics -- if some (or all) default metrics were disabled or weren't enabled, they won't be appear in observation. The motivation is a requirement from Tarantool Feedback Daemon [1] to collect default metrics, but not the user ones. 1. tarantool/tarantool#8192 Part of tarantool/tarantool#8192, part of tarantool/tarantool#7725
If branch name has slash in name, it didn't passes the `'*'` Github Actions regexp.
DifferentialOrange
force-pushed
the
DifferentialOrange/lua-exporter
branch
from
948fd7e to
dceb3d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several features to
collect()handle and collectors so it would be possible to conveniently collect default metrics from Lua. This feature is required by the core team to deal with Tarantool Feedback Daemon default metrics collect (see tarantool/tarantool#8192).See commit messages for more detailed info.
I didn't forget about
Part of tarantool/tarantool#8192, part of tarantool/tarantool#7725