Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when http_middelware is processing a wrong handler #296

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Throw an error when http_middelware is processing a wrong handler #296

merged 3 commits into from
Sep 9, 2021

Conversation

yngvar-antonsson
Copy link
Collaborator

@yngvar-antonsson yngvar-antonsson commented Sep 8, 2021 •
edited
Loading

I didn't forget about

  • Tests
  • Changelog

Close #199

DifferentialOrange
DifferentialOrange requested changes Sep 9, 2021
View reviewed changes
metrics/http_middleware.lua Outdated Show resolved Hide resolved
metrics/http_middleware.lua Outdated Show resolved Hide resolved
@yngvar-antonsson yngvar-antonsson merged commit df62af8 into master Sep 9, 2021
@yngvar-antonsson yngvar-antonsson deleted the http-middleware branch September 9, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DifferentialOrange DifferentialOrange DifferentialOrange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process latency count more carefully
2 participants
@yngvar-antonsson @DifferentialOrange