Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include and exclude section in config #268

Merged
merged 8 commits into from
Aug 2, 2021

Conversation

yngvar-antonsson
Copy link
Collaborator

@yngvar-antonsson yngvar-antonsson commented Jul 9, 2021

I've added include and exclude sections to config to configure which metrics are exported.

When you add include section, only metrics from this section are exported:

metrics:
  export: ...
  # export only vinyl, luajit and memory metrics:
  include:
  - vinyl
  - luajit
  - memory

When you add exclude section, metrics from this section are removed from default metrics list:

metrics:
  export: ...
  # export all metrics except vinyl, luajit and memory:
  exclude:
  - vinyl
  - luajit
  - memory

I didn't forget about

  • Tests
  • Changelog
  • Documentation (README and rst)

Close #222

cartridge/roles/metrics.lua Outdated Show resolved Hide resolved
cartridge/roles/metrics.lua Outdated Show resolved Hide resolved
@opomuc opomuc mentioned this pull request Jul 16, 2021
@yngvar-antonsson yngvar-antonsson force-pushed the configure-exported-metrics branch from ab25045 to 0323af9 Compare July 21, 2021 11:55
@yngvar-antonsson yngvar-antonsson force-pushed the configure-exported-metrics branch from 0323af9 to a11724b Compare July 21, 2021 11:56
metrics/default_metrics/tarantool/init.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/init.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/init.lua Show resolved Hide resolved
metrics/registry.lua Outdated Show resolved Hide resolved
test/integration/cartridge_role_test.lua Outdated Show resolved Hide resolved
test/integration/cartridge_role_test.lua Outdated Show resolved Hide resolved
@yngvar-antonsson yngvar-antonsson force-pushed the configure-exported-metrics branch from 1847e26 to 6e73349 Compare July 27, 2021 14:30
cartridge/roles/metrics.lua Show resolved Hide resolved
cartridge/roles/metrics.lua Show resolved Hide resolved
metrics/registry.lua Outdated Show resolved Hide resolved
cartridge/roles/metrics.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/init.lua Show resolved Hide resolved
metrics/cartridge/clock.lua Show resolved Hide resolved
metrics/default_metrics/tarantool/memory.lua Outdated Show resolved Hide resolved
metrics/registry.lua Outdated Show resolved Hide resolved
metrics/tarantool/luajit.lua Show resolved Hide resolved
Co-authored-by: Yaroslav Dynnikov <[email protected]>
@yngvar-antonsson yngvar-antonsson force-pushed the configure-exported-metrics branch from 627e465 to 40009c5 Compare July 30, 2021 18:08
@yngvar-antonsson yngvar-antonsson merged commit ccf6bb6 into master Aug 2, 2021
@yngvar-antonsson yngvar-antonsson deleted the configure-exported-metrics branch August 2, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash table of registered callbacks instead of list Unregister callback Make metrics config more flexible
4 participants