Repeat _each / _test hooks #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steap2448
force-pushed
the
161-repeat-each-hooks
branch
from
ff15fb0 to
740335f
Compare
rosik
reviewed
Sep 7, 2021
test/hooks_test.lua
Outdated
Comment on lines
329
to
346
| t.assert_equals(hooks, { | ||
| 'before_each', 'before_test', 'test_a', 'after_each', | ||
| 'before_each', 'before_test', 'test_a', 'after_each', | ||
| 'before_each', 'test_b', 'after_test', 'after_each', | ||
| 'before_each', 'test_b', 'after_test', 'after_each', | ||
| }) |
There was a problem hiding this comment.
Would you like to extend it with before_all and after_all?
Also, are there tests that cover:
- an error in
before_eachin conjunction with--repeatoption - a case when n-th test fails
There was a problem hiding this comment.
Would you like to extend it with before_all and after_all?
I don't think that repeating _all hooks is a good idea. They are supposed to be before and after all tests (evidently), but with the repeat option it won't be this way.
There was a problem hiding this comment.
I didn't mean calling before_all twice but extending the test with it. Never mind, you can merge it as is.
There was a problem hiding this comment.
My bad. Added it to the test
Steap2448
force-pushed
the
161-repeat-each-hooks
branch
from
740335f to
ace63c8
Compare
rosik
approved these changes
Sep 10, 2021
Steap2448
force-pushed
the
161-repeat-each-hooks
branch
from
ace63c8 to
48f435b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeat
_eachand_testhooks when-roption is specified.I didn't forget about
DocumentationClose #161