Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarantool 3 support: phase 1 #228

Merged

Conversation

DifferentialOrange
Copy link
Member

This PR covers the following:

  • rename all Cartrdge-related stuff to explicitly specify Cartridge,
  • introduce Tarantool 3 dashboard and toolchain (not released yet!);
  • use Tarantool 3 dashboard components as a default for custom build.

For now Tarantool 3 dashboard is Tarantool Cartridge dashboard without Cartridge-specific metrics. The main reason behind this is that current Tarantool 3 releases does not yet contain metrics like tarantool/metrics#491, so it makes sence to have at least one release where every panel works.

The dashboard will be released in next PR.

Part of #224

Explicitly mark all entries of current default dashboard as a
dashboard for Tarantool Cartridge and Tarantool 1.10--2.x applications.
Grafana pages had been updated as well.

Part of #224
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

end

elseif operation == UPDATE then
-- Will also generate non-null map reduces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- Will also generate non-null map reduces
-- Will also generate non-null map reduces.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -0,0 +1,6 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

engine = 'memtx',
is_sync = true,
})
-- primary index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- primary index
-- Primary index.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Introduce Tarantool 3 cluster for manual Tarantool 3 dashboard check-up
and screenshot making (for repo, PRs and official pages).

Part of #224
Some panels dealing with cluster overview (supported only for
Prometheus) expect to have each instance as a separate pull target
since they rely on Prometheus target `up` healthcheck. They won't
work properly when something like TCM is used to provide metrics for
the whole cluster. This patch adds a note to clarify this.

Part of #224
This patch renames `cluster` and `replication` overview panels sections
to `cluster_cartridge` and `replication_cartridge` since they use
Cartridge-specific metrics [1]. This is a breaking change for all
custom-built dashboard which had used them. It has no effect on our
published dashboards.

1. tarantool/metrics#491

Part of #224
After introducing config-based static (actually, not only static) builds
in [1] old way of static building through `make` was deprecated. Since
we'll need to extend deprecated commands to support Tarantool 3 and
Tarantool Cartridge at the same time, it's a good motivation to remove
them.

1. #206

Part of #224
For now the only difference between Tarantool Cartridge and Tarantool 3
dashboard is that the latter is missing some Cartridge-only panels.

Part of #224
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-224-tarantool-3-phase-1 branch from 7ed68df to 8c6f86f Compare July 8, 2024 14:21
@DifferentialOrange DifferentialOrange merged commit 9ffc334 into master Jul 8, 2024
1 check passed
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/gh-224-tarantool-3-phase-1 branch July 8, 2024 14:23
DifferentialOrange added a commit that referenced this pull request Jul 8, 2024
After #228, dashboard started to use non-existing test artifacts
for volumes. This patch fixes the issue.

Follows #228
DifferentialOrange added a commit that referenced this pull request Jul 8, 2024
After #228, Grafana started to use non-existing test artifacts
for startup volumes. This patch fixes the issue.

Follows #228
DifferentialOrange added a commit that referenced this pull request Jul 9, 2024
After #228, Grafana started to use non-existing test artifacts
for startup volumes. This patch fixes the issue.

Follows #228
DifferentialOrange added a commit that referenced this pull request Jul 9, 2024
It should've been removed in #228 after deprecated make commands remove,
but I had missed it.

Part of #224
DifferentialOrange added a commit that referenced this pull request Jul 9, 2024
It should've been removed in #228 after deprecated make commands remove,
but I had missed it.

Part of #224
@DifferentialOrange DifferentialOrange mentioned this pull request Jul 9, 2024
15 tasks
DifferentialOrange added a commit that referenced this pull request Jul 9, 2024
It should've been removed in #228 after deprecated make commands remove,
but I had missed it.

Part of #224
DifferentialOrange added a commit that referenced this pull request Jul 9, 2024
It should've been removed in #228 after deprecated make commands remove,
but I had missed it.

Part of #224
DifferentialOrange added a commit that referenced this pull request Jul 9, 2024
It should've been removed in #228 after deprecated make commands remove,
but I had missed it.

Part of #224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants