pool: add missing methods to the pooler interface #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekBum
requested changes
May 2, 2024
There was a problem hiding this comment.
Just few non-critical notes:
- Please, fix the review comments in the same commit (
git commit --amend+git push --force) - Please, add the changelog entry after this line:
Line 15 in c9ff313
Something like this:
## Added
- ...
- Methods that are implemented but not included in the pooler interface
- Please, update the commit message. It could be something like:
pool: add missing methods to the pooler interface
I added methods that are implemented but not included in the pooler interface.
It will help us to have commits in the same style.
KaymeKaydex
force-pushed
the
feature/pooler
branch
from
c9ff313 to
f58a43d
Compare
|
@DerekBum , thanks for the review, I have corrected all, please check it again |
KaymeKaydex
changed the title
oleg-jukovec
reviewed
May 6, 2024
KaymeKaydex
force-pushed
the
feature/pooler
branch
from
f58a43d to
74b12c1
Compare
DerekBum
approved these changes
May 6, 2024
I added methods that are implemented but not included in the pooler interface.
KaymeKaydex
force-pushed
the
feature/pooler
branch
from
74b12c1 to
e7448fe
Compare
oleg-jukovec
approved these changes
May 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added methods that are implemented but not included in the pooler interface