Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UUID submodule dependency is broken #134

Closed
DifferentialOrange opened this issue Jan 14, 2022 · 0 comments · Fixed by #135
Closed

UUID submodule dependency is broken #134

DifferentialOrange opened this issue Jan 14, 2022 · 0 comments · Fixed by #135
Assignees
@DifferentialOrange
Labels
bug Something isn't working code health Improve code readability, simplify maintenance and so on help wanted Extra attention is needed

Comments

@DifferentialOrange
Copy link
Member

DifferentialOrange commented Jan 14, 2022 •
edited
Loading

Reproducer:

package main

import (
	_ "github.com/tarantool/go-tarantool"
	_ "github.com/tarantool/go-tarantool/uuid"
)
go mod tidy

github.com/tarantool/go-tarantool v0.0.0-20211104105631-61f3a41907b6/go.mod h1:m/mppmrDtgvS3tqUvaZRdRtlgzK1Gz/T6uGndkOItmQ=
github.com/tarantool/go-tarantool v0.0.0-20220113162241-9c9a68e09870 h1:oVoH+fRulel/M1XIbYlhO2tAiLXK1FT+GQQwfMkkDqM=
github.com/tarantool/go-tarantool v0.0.0-20220113162241-9c9a68e09870/go.mod h1:J//scltxiWkCB+p3u0w1cMoyiMIV1p0bttckvHY1qnQ=
github.com/tarantool/go-tarantool/uuid v0.0.0-20220113162241-9c9a68e09870 h1:z2zfPmgIKsEojgVaULH1su9PNJGn+k/NwFGjVtkVqhc=
github.com/tarantool/go-tarantool/uuid v0.0.0-20220113162241-9c9a68e09870/go.mod h1:yDmq7heOcE3N/ZlpCXxUUpluM7frb6+g6ugo7apYVtE=

Since go-tarantool/uuid is a separate submodule (see #104 comments) and it requires original module to run tests, it uses github.com/tarantool/go-tarantool as a dependency. And them we have problems:

  1. when I install go-tarantool+uuid, my application has two go-tarantool dependencies;
  2. when I change something in main module, I cannot use it in submodule test since it points to some github master (and moving a pointer to a branch would not be a good solution either).

The only way I see now is to completely remove uuid_test.go, which isn't a good one.
@DifferentialOrange DifferentialOrange added bug Something isn't working code health Improve code readability, simplify maintenance and so on help wanted Extra attention is needed labels Jan 14, 2022
@DifferentialOrange DifferentialOrange self-assigned this Jan 14, 2022
DifferentialOrange added a commit that referenced this issue Jan 14, 2022
@DifferentialOrange
uuid: use plain package instead of module
8ad21b2 
Using separate module instead of plain package introduced several
issues related to dependencies inside the repository (see #134).
At the same time, same functionality could be provided with package.
The only drawback is that google/uuid will be included in main
package dependency even if user decide to use custom UUID parser or
ignore UUID completely.

Closes #134
This was referenced Jan 14, 2022
Merged
Merged
DifferentialOrange added a commit that referenced this issue Jan 31, 2022
@DifferentialOrange
uuid: use plain package instead of module
56cb3ef 
Using separate module instead of plain package introduced several
issues related to dependencies inside the repository (see #134).
At the same time, same functionality could be provided with package.
The only drawback is that google/uuid will be included in main
package dependency even if user decide to use custom UUID parser or
ignore UUID completely.

Closes #134
ligurio pushed a commit that referenced this issue Mar 7, 2022
@DifferentialOrange @ligurio
uuid: use plain package instead of module
aacc00f 
Using separate module instead of plain package introduced several
issues related to dependencies inside the repository (see #134).
At the same time, same functionality could be provided with package.
The only drawback is that google/uuid will be included in main
package dependency even if user decide to use custom UUID parser or
ignore UUID completely.

Closes #134
ligurio pushed a commit that referenced this issue Mar 30, 2022
@DifferentialOrange @ligurio
uuid: use plain package instead of module
d569380 
Using separate module instead of plain package introduced several
issues related to dependencies inside the repository (see #134).
At the same time, same functionality could be provided with package.
The only drawback is that google/uuid will be included in main
package dependency even if user decide to use custom UUID parser or
ignore UUID completely.

Closes #134
ligurio pushed a commit that referenced this issue Apr 7, 2022
@DifferentialOrange @ligurio
uuid: use plain package instead of module
a335c0b 
Using separate module instead of plain package introduced several
issues related to dependencies inside the repository (see #134).
At the same time, same functionality could be provided with package.
The only drawback is that google/uuid will be included in main
package dependency even if user decide to use custom UUID parser or
ignore UUID completely.

Closes #134
@LeonidVas LeonidVas added the teamE label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DifferentialOrange DifferentialOrange

Labels
bug Something isn't working code health Improve code readability, simplify maintenance and so on help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

uuid: use plain package instead of module tarantool/go-tarantool
2 participants
@DifferentialOrange @LeonidVas