Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UUID keys comparison #86

Merged
merged 14 commits into from
Dec 7, 2020
Merged

Add support for UUID keys comparison #86

merged 14 commits into from
Dec 7, 2020

Conversation

akudiyar
Copy link
Contributor

@akudiyar akudiyar commented Nov 11, 2020 •
edited
Loading

Add support for indexes with UUID key parts. UUID comparison is done via the uuid:str() method and may be further replaced with a more efficient comparison using tt_uuid_compare (see tarantool/tarantool#5511)

I didn't forget about

  • Tests
  • Changelog
  • Documentation

Closes #84

@akudiyar akudiyar requested a review from dokshina November 11, 2020 13:00
olegrok
olegrok reviewed Nov 11, 2020
View reviewed changes
crud/common/types.lua Outdated Show resolved Hide resolved
crud/common/types.lua Outdated Show resolved Hide resolved
crud/common/types.lua Outdated Show resolved Hide resolved
test/unit/select_comparators_test.lua Outdated Show resolved Hide resolved
test/unit/select_comparators_test.lua Show resolved Hide resolved
test/integration/select_test.lua Outdated Show resolved Hide resolved
dokshina
dokshina reviewed Nov 12, 2020
View reviewed changes
crud/common/utils.lua Outdated Show resolved Hide resolved
dokshina
dokshina reviewed Nov 12, 2020
View reviewed changes
crud/select/filters.lua Outdated Show resolved Hide resolved
dokshina
dokshina reviewed Nov 12, 2020
View reviewed changes
crud/select/filters.lua Outdated Show resolved Hide resolved
dokshina
dokshina reviewed Nov 12, 2020
View reviewed changes
crud/select/filters.lua Outdated Show resolved Hide resolved
dokshina
dokshina reviewed Nov 12, 2020
View reviewed changes
crud/common/types.lua Outdated Show resolved Hide resolved
dokshina
dokshina reviewed Nov 12, 2020
View reviewed changes
crud/common/types.lua Outdated Show resolved Hide resolved
dokshina
dokshina reviewed Nov 12, 2020
View reviewed changes
crud/common/types.lua Outdated Show resolved Hide resolved
dokshina
dokshina reviewed Nov 12, 2020
View reviewed changes
crud/common/types.lua Outdated Show resolved Hide resolved
dokshina
dokshina reviewed Nov 12, 2020
View reviewed changes
crud/common/types.lua Outdated Show resolved Hide resolved
@dokshina
Copy link
Contributor

dokshina commented Dec 7, 2020

Please, rebase your branch and I will merge it immediately.

@dokshina dokshina merged commit c6eb641 into master Dec 7, 2020
@dokshina dokshina deleted the gh-84 branch December 7, 2020 11:47
@DifferentialOrange DifferentialOrange mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokshina dokshina dokshina approved these changes

@olegrok olegrok Awaiting requested review from olegrok

@mtrempoltsev mtrempoltsev Awaiting requested review from mtrempoltsev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support UUIDs as keys
4 participants
@akudiyar @dokshina @mtrempoltsev @olegrok