Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not install metrics for reusable test #429

Conversation

DifferentialOrange
Copy link
Member

metrics 1.0.0 cannot be installed together with Tarantool 3.x: they override built-in ones, but they're too old to work with 3.x default setup which uses [1].

  1. tarantool/metrics@4865675

I didn't forget about

  • Tests

metrics 1.0.0 cannot be installed together with Tarantool 3.x: they
override built-in ones, but they're too old to work with 3.x config
default setup which uses [1].

1. tarantool/metrics@4865675
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no-gh-remove-metrics-for-master branch from 8d6865f to ef1c3c4 Compare April 3, 2024 14:43
@DifferentialOrange DifferentialOrange requested a review from nshy April 3, 2024 14:44
Copy link

@nshy nshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@0x501D 0x501D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DifferentialOrange DifferentialOrange merged commit 87e12e0 into master Apr 3, 2024
25 checks passed
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/no-gh-remove-metrics-for-master branch April 3, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants