api: return error if no tuples/objects #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-377-no-rows-error
branch
2 times, most recently
from
d9f088a to
c395f3c
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/no-gh-schema
branch
2 times, most recently
from
00ebe5f to
06a92c8
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-377-no-rows-error
branch
from
c395f3c to
1aad7d2
Compare
Before this patch, the behavior of `*_many` requests if empty array of
tuples/objects were rather confusing. For example, due to format
processing all `*_object_many` operations resulted in `nil, {}` --
error request with zero errors. `insert_many` and `replace_many` calls
result in `nil, nil` -- no result, no error. `upsert_many` results in
`{metadata = metadata}, nil` with no `rows` in response. Thus, for all
six `*_many` calls trying to execute the request with empty array on
input result in malformed response.
After this patch, trying to run `*_many` request with empty array of
tuples/objects will result in `nil, {err}`, similar to existing
`*_many` API. Single tuple crud API already does not allow to run with
no tuples/objects.
Closes #377
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-377-no-rows-error
branch
from
1aad7d2 to
9f0e33e
Compare
better0fdead
approved these changes
Oct 9, 2023
DifferentialOrange
deleted the
DifferentialOrange/gh-377-no-rows-error
branch
DifferentialOrange
restored the
DifferentialOrange/gh-377-no-rows-error
branch
DifferentialOrange
deleted the
DifferentialOrange/gh-377-no-rows-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the behavior of
*_manyrequests if empty array of tuples/objects were rather confusing. For example, due to format processing all*_object_manyoperations resulted innil, {}-- error request with zero errors.insert_manyandreplace_manycalls result innil, nil-- no result, no error.upsert_manyresults in{metadata = metadata}, nilwith norowsin response. Thus, for all six*_manycalls trying to execute the request with empty array on input result in malformed response.After this patch, trying to run
*_manyrequest with empty array of tuples/objects will result innil, {err}, similar to existing*_manyAPI. Single tuple crud API already does not allow to run with no tuples/objects.Closes #377