readview: fix garbagecollector #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
reviewed
Oct 4, 2023
| end, res) | ||
| t.assert_equals(res, {["s-1"] = {}, ["s-2"] = {}}) | ||
| t.assert_equals(res, {{}, {}, {}, {}}) |
There was a problem hiding this comment.
This is wrong indentation (and at the previous line too.
oleg-jukovec
approved these changes
Oct 4, 2023
better0fdead
force-pushed
the
better0fdead/gc-fix-readview
branch
from
a73011d to
7dc1adf
Compare
better0fdead
force-pushed
the
better0fdead/gc-fix-readview
branch
from
7dc1adf to
b465cae
Compare
DifferentialOrange
requested changes
Oct 4, 2023
better0fdead
force-pushed
the
better0fdead/gc-fix-readview
branch
from
b465cae to
1b5a9ca
Compare
DifferentialOrange
approved these changes
Oct 4, 2023
Added workaround for 'garbagecollector' of readview because for tarantool lua (and lua 5.1) '__gc' metamethod only works for cdata types. See tarantool/tarantool#5770
better0fdead
force-pushed
the
better0fdead/gc-fix-readview
branch
from
1b5a9ca to
1645e1b
Compare
DifferentialOrange
added a commit
that referenced
this pull request
Oct 16, 2023
Overview This release improves experience for VShard clusters users and Tarantool 3 users. It also introduces schema introspection API. New features * Space schema introspection API `crud.schema` (#380). Bugfixes * Return explicit error for `*_many` call with no tuples/objects (#377). * `crud.readview` resource cleanup on garbage collect (#379). * VShard storage user have not execution rights for internal functions (#366). Infrastructure * `deps.sh` installs the `vshard` instead of the `cartridge` by default (#364). You could to specify an environment variable `CARTIRDGE_VERSION` to install the `cartridge` and run tests cases with it. * `doc/playground.lua` does not work with Tarantool 3 (#371). * Tests with Tarantool 3 (#364). * Quickstart section in the README.md focuses on usage with `vshard` instead of `Cartridge` (#366).
Merged
DifferentialOrange
added a commit
that referenced
this pull request
Oct 16, 2023
Overview This release improves experience for VShard clusters users and Tarantool 3 users. It also introduces schema introspection API. New features * Space schema introspection API `crud.schema` (#380). Bugfixes * Return explicit error for `*_many` call with no tuples/objects (#377). * `crud.readview` resource cleanup on garbage collect (#379). * VShard storage user have not execution rights for internal functions (#366). * Compatibility with Tarantool 3.0 tuple objects (#387). Infrastructure * `deps.sh` installs the `vshard` instead of the `cartridge` by default (#364). You could to specify an environment variable `CARTIRDGE_VERSION` to install the `cartridge` and run tests cases with it. * `doc/playground.lua` does not work with Tarantool 3 (#371). * Tests with Tarantool 3 (#364). * Quickstart section in the README.md focuses on usage with `vshard` instead of `Cartridge` (#366).
DifferentialOrange
added a commit
that referenced
this pull request
Oct 16, 2023
Overview This release improves experience for VShard clusters users and Tarantool 3 users. It also introduces schema introspection API. New features * Space schema introspection API `crud.schema` (#380). Bugfixes * Return explicit error for `*_many` call with no tuples/objects (#377). * `crud.readview` resource cleanup on garbage collect (#379). * VShard storage user have not execution rights for internal functions (#366). * Compatibility with Tarantool 3.0 tuple objects (#387). Infrastructure * `deps.sh` installs the `vshard` instead of the `cartridge` by default (#364). You could to specify an environment variable `CARTIRDGE_VERSION` to install the `cartridge` and run tests cases with it. * `doc/playground.lua` does not work with Tarantool 3 (#371). * Tests with Tarantool 3 (#364). * Quickstart section in the README.md focuses on usage with `vshard` instead of `Cartridge` (#366).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added workaround for garbagecollection of readview because for tarantool lua (and lua 5.1) __gc metamethod only works for cdata types.
See tarantool/tarantool#5770
What has been done? Why? What problem is being solved?
I didn't forget about