ddl: fix fetching invalid configuration #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, in case there is a sharding key record in _ddl_sharding_key for a non-existing space (for example, if ddl space wasn't properly dropped) and sharding info needs to be updated, any crud request will fail with "attempt to index a nil value" error. This patch fixes the behavior and adds a log warning if ddl configuration is invalid. Closes #308
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-308-fail-after-drop
branch
from
bdc46cc to
d0d8206
Compare
iDneprov
approved these changes
Jul 20, 2022
AnaNek
approved these changes
Jul 21, 2022
DifferentialOrange
added a commit
that referenced
this pull request
Jul 21, 2022
Fix changelog typo introduced in PR #309.
DifferentialOrange
added a commit
that referenced
this pull request
Jul 21, 2022
Overview
This is a bugfix release. It introduces several fixes related
to crud and ddl module integration.
Breaking changes
There are no breaking changes in the release.
Bugfixes
* Fetching invalid ddl configuration (sharding key for non-existing
space) is no longer breaks CRUD requests (#308, PR #309).
* ddl space record delete no more throws error if crud
is used (#310, PR #311).
* crud sharding metainfo is now updated on ddl record
delete (#310, PR #311).
DifferentialOrange
added a commit
that referenced
this pull request
Jul 21, 2022
Fix changelog typo introduced in PR #309.
DifferentialOrange
added a commit
that referenced
this pull request
Jul 21, 2022
Overview
This is a bugfix release. It introduces several fixes related
to crud and ddl module integration.
Breaking changes
There are no breaking changes in the release.
Bugfixes
* Fetching invalid ddl configuration (sharding key for non-existing
space) is no longer breaks CRUD requests (#308, PR #309).
* ddl space record delete no more throws error if crud
is used (#310, PR #311).
* crud sharding metainfo is now updated on ddl record
delete (#310, PR #311).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, in case there is a sharding key record in _ddl_sharding_key for a non-existing space (for example, if ddl space wasn't properly dropped) and sharding info needs to be updated, any crud request will fail with "attempt to index a nil value" error. This patch fixes the behavior and adds a log warning if ddl configuration is invalid.
I didn't forget about
Closes #308