Disallow using space_id #255

DifferentialOrange · 2022-01-13T10:41:14Z

crud.len allows to using space_id instead of space_name:

Lines 39 to 40 in 76e3374

    
           function len.call(space_name, opts) 
        
               checks('string|number', {

AFAIK, every other crud method do not support it, so there is an inconsistency. There are two possible ways, and it seems like it is better to prohibit using space_id since in sharded system its consistency is not guaranteed: see @olegrok #244 (comment)

The text was updated successfully, but these errors were encountered:

`crud.len` supports using space id instead of name. After this patch, stats wrapper support mapping id to name. Since using space id is a questionable pattern (see #255), this commit may be reverted later. Part of #224

CRUD stats are separated by space name. If space id is passed instead of name (only `crud.len` allows this), space name is resolved with net_box schema. Since, after resolving #44, non-default vshard routers and Cartridge vshard groups are supported, to resolve the name we must know what vshard router should be used. Since using space id for `crud.len` is deprecated now, we won't support name resolve for operations with custom router statistics. Instead of this, a warning will be logged. `crud.len` statistics will be signed by space name or space id casted to string depending on is there a default router with space schema or not. Follows up #44, part of #255

Part of #255

CRUD stats are separated by space name. If space id is passed instead of name (only `crud.len` allows this), space name is resolved with net_box schema. Since, after resolving #44, non-default vshard routers and Cartridge vshard groups are supported, to resolve the name we must know what vshard router should be used. Since using space id for `crud.len` is deprecated now, we won't support name resolve for operations with custom router statistics. Instead of this, a warning will be logged. `crud.len` statistics will be signed by space name or space id casted to string depending on is there a default router with space schema or not. Follows up #44, part of #255

Part of #255

CRUD stats are separated by space name. If space id is passed instead of name (only `crud.len` allows this), space name is resolved with net_box schema. Since, after resolving #44, non-default vshard routers and Cartridge vshard groups are supported, to resolve the name we must know what vshard router should be used. Since using space id for `crud.len` is deprecated now, we won't support name resolve for operations with custom router statistics. Instead of this, a warning will be logged. `crud.len` statistics will be signed by space name or space id casted to string depending on is there a default router with space schema or not. Follows up #44, part of #255

Part of #255

CRUD stats are separated by space name. If space id is passed instead of name (only `crud.len` allows this), space name is resolved with net_box schema. Since, after resolving #44, non-default vshard routers and Cartridge vshard groups are supported, to resolve the name we must know what vshard router should be used. Since using space id for `crud.len` is deprecated now, we won't support name resolve for operations with custom router statistics. Instead of this, a warning will be logged. `crud.len` statistics will be signed by space name or space id casted to string depending on is there a default router with space schema or not. Follows up #44, part of #255

Overview This release introduces vshard group and non-default vshard routers support. To use a space Cartridge vshard group, pass group name to a request a `vshard_group` request option. ```lua local res, err = crud.select('customers', {{'<=', 'age', 35}}, {first = 10, vshard_group = 'hot'}) ``` To use non-default vshard router, pass router object to a request. ```lua local vshard_router = vshard.router.new(name, cfg) local res, err = crud.select('customers', {{'<=', 'age', 35}}, {first = 10, vshard_group = vshard_router}) ``` New features * vshard group and non-default vshard routers support (#44). Changes * Deprecate using space id in crud.len (#255).

Overview This release introduces vshard group and non-default vshard routers support. To use a space Cartridge vshard group, pass group name to a request `vshard_group` option. ```lua local res, err = crud.select('customers', {{'<=', 'age', 35}}, {first = 10, vshard_group = 'hot'}) ``` To use non-default vshard router, pass router object to a request. ```lua local vshard_router = vshard.router.new(name, cfg) local res, err = crud.select('customers', {{'<=', 'age', 35}}, {first = 10, vshard_group = vshard_router}) ``` New features * vshard group and non-default vshard routers support (#44). Changes * Deprecate using space id in crud.len (#255).

Overview This release introduces vshard group and non-default vshard routers support. To use a space Cartridge vshard group, pass group name to a request `vshard_group` option. ```lua local res, err = crud.select('customers', {{'<=', 'age', 35}}, {first = 10, vshard_group = 'hot'}) ``` To use non-default vshard router, pass router object to a request `vshard_group` option. ```lua local my_router = vshard.router.new(name, cfg) local res, err = crud.select('customers', {{'<=', 'age', 35}}, {first = 10, vshard_group = my_router}) ``` New features * vshard group and non-default vshard routers support (#44). Changes * Deprecate using space id in crud.len (#255).

Using space id instead of a space name in sharded systems may be dangerous until one sets all space id manually. This is a breaking change. The feature was deprecated since 0.14.0. Closes #255

Overview This release introduces a breaking change with removing a deprecated feature: `crud.len(space_id)`. This release also introduces a Cartridge clusterwide config to setup `crud.cfg`. Breaking changes You cannot use space id as a space identifier in `crud.len` anymore. Use space name instead. New features * Timeout condition for the validation of master presence in replicaset and for the master connection (#95). * Cartridge clusterwide configuration for `crud.cfg` (#332). Changes * Forbid using space id in `crud.len` (#255). Fixes * Add validation of the master presence in replicaset and the master connection to the `utils.get_space` method before receiving the space from the connection (#331). * Fix fiber cancel on schema reload timeout in `call_reload_schema` (PR #337).

Overview This release introduces a breaking change with removing a deprecated feature: `crud.len(space_id)`. This release also introduces a Cartridge clusterwide config to setup `crud.cfg`. Breaking changes You cannot use space id as a space identifier in `crud.len` anymore. Use space name instead. New features * Timeout condition for the validation of master presence in replicaset and for the master connection (#95). * Cartridge clusterwide configuration for `crud.cfg` (#332). Changes * Forbid using space id in `crud.len` (#255). Fixes * Add validation of the master presence in replicaset and the master connection to the `utils.get_space` method before receiving the space from the connection (#331). * Fix fiber cancel on schema reload timeout in `call_reload_schema` (PR #336).

DifferentialOrange added invalid This doesn't seem right needs feedback Something is unclear with the issue question Further information is requested teamE bug Something isn't working and removed invalid This doesn't seem right needs feedback Something is unclear with the issue labels Jan 13, 2022

DifferentialOrange mentioned this issue Jan 13, 2022

Add statistics for CRUD operations on router #244

Merged

3 tasks

DifferentialOrange added a commit that referenced this issue Aug 29, 2022

api: deprecate using space id in len

a358f51

Part of #255

DifferentialOrange added a commit that referenced this issue Aug 29, 2022

api: deprecate using space id in len

e5742cb

Part of #255

DifferentialOrange added a commit that referenced this issue Aug 31, 2022

api: deprecate using space id in len

1920cca

Part of #255

DifferentialOrange mentioned this issue Sep 13, 2022

Release 0.14.0 #322

Merged

DifferentialOrange self-assigned this Jan 27, 2023

DifferentialOrange mentioned this issue Jan 27, 2023

api: forbid using space id in len #338

Merged

2 tasks

DifferentialOrange closed this as completed in #338 Jan 30, 2023

DifferentialOrange mentioned this issue Feb 2, 2023

release: 1.0.0 #340

Merged

1 task

DifferentialOrange mentioned this issue Feb 13, 2023

api: add CRUD module support tarantool/go-tarantool#263

Merged

24 tasks

DifferentialOrange mentioned this issue Mar 22, 2023

Support field id in select/pairs conditions #352

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disallow using space_id #255

Disallow using space_id #255

DifferentialOrange commented Jan 13, 2022

Disallow using space_id #255

Disallow using space_id #255

Comments

DifferentialOrange commented Jan 13, 2022