Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify doesNotThrow parameters #450

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Clarify doesNotThrow parameters #450

merged 1 commit into from
Nov 25, 2018
+1 −1

Commits on Nov 25, 2018

  1. Clarify doesNotThrow parameters 

    To prevent issues like tape-testing#334, here is a proposal to clarify the purpose of the second argument. My own first reaction to the second argument was like "Whaaat, the docs cannot be right. Even the mere word 'expected' is against the purpose of the assertion. How we can expect something that is not thrown. The argument cannot have any meaning." Then I browsed through the issues, found tape-testing#334 and then it became clear.
    @axelpale
    axelpale authored Nov 25, 2018
    Configuration menu
    Copy the full SHA
    f53e3f1 View commit details
    Browse the repository at this point in the history