Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of synchronous children of async tests #252

Closed
wants to merge 4 commits into from
Closed

Fix order of synchronous children of async tests #252

wants to merge 4 commits into from

Commits on Feb 13, 2016

  1. test: add test cases for async tests with synchronous children

    @kl0tl
    kl0tl committed Feb 13, 2016
    Configuration menu
    Copy the full SHA
    d2f573c View commit details
    Browse the repository at this point in the history

  2. fix: listen to the beforeExit event instead of calling nextTick

    @kl0tl
    kl0tl committed Feb 13, 2016
    Configuration menu
    Copy the full SHA
    099488d View commit details
    Browse the repository at this point in the history

  3. fix: don’t let tap default timeout prevent nested tests to run 

    If no `timeout` option is provided `tap` waits 30 seconds before ending the test. The timer block the `beforeExit` event and prevent the nested tests to ever run.
    @kl0tl
    kl0tl committed Feb 13, 2016
    Configuration menu
    Copy the full SHA
    e3111e8 View commit details
    Browse the repository at this point in the history

  4. fix: don’t let timeouts prevent nested tests to run 

    If a test is supposed to be implicitly ended by its children a timer will fail it and prevent its children to run.
    @kl0tl
    kl0tl committed Feb 13, 2016
    Configuration menu
    Copy the full SHA
    7edaa7d View commit details
    Browse the repository at this point in the history