[Tests] fix stack differences on node 0.8

tape-testing · Dec 4, 2016 · c7859a2 · c7859a2
1 parent 9302682
commit c7859a2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/test/common.js b/test/common.js
@@ -22,6 +22,7 @@ module.exports.getDiag = function (body) {
 //    placeholder $TEST variable.
 // 2) Line positions within the file might change. We handle this by replacing
 //    line and column markers with placeholder $LINE and $COL "variables"
+//   a) node 0.8 does not provide nested eval line numbers, so we remove them
 // 3) Stacks themselves change frequently with refactoring. We've even run into
 //    issues with node library refactorings "breaking" stack traces. Most of
 //    these changes are irrelevant to the tests themselves. To counter this, we
@@ -35,7 +36,8 @@ module.exports.stripFullStack = function (output) {
       var stripChangingData = function (line) {
           var withoutDirectory = line.replace(__dirname, '$TEST');
           var withoutLineNumbers = withoutDirectory.replace(/:\d+:\d+/g, ':$LINE:$COL');
-          return withoutLineNumbers;
+          var withoutNestedLineNumbers = withoutLineNumbers.replace(/, \<anonymous\>:\$LINE:\$COL\)$/, ')');
+          return withoutNestedLineNumbers;
       }
 
       if (m) {

diff --git a/test/exit.js b/test/exit.js
@@ -56,8 +56,8 @@ tap.test('exit fail', function (t) {
             '      Error: should be equivalent',
             '          [... stack stripped ...]',
             '          at $TEST/exit/fail.js:$LINE:$COL',
-            '          at eval (eval at <anonymous> ($TEST/exit/fail.js:$LINE:$COL), <anonymous>:$LINE:$COL)',
-            '          at eval (eval at <anonymous> ($TEST/exit/fail.js:$LINE:$COL), <anonymous>:$LINE:$COL)',
+            '          at eval (eval at <anonymous> ($TEST/exit/fail.js:$LINE:$COL))',
+            '          at eval (eval at <anonymous> ($TEST/exit/fail.js:$LINE:$COL))',
             '          at Test.<anonymous> ($TEST/exit/fail.js:$LINE:$COL)',
             '          [... stack stripped ...]',
             '  ...',

diff --git a/test/fail.js b/test/fail.js
@@ -26,8 +26,8 @@ tap.test('array test', function (tt) {
             '      Error: should be equivalent',
             '          [... stack stripped ...]',
             '          at $TEST/fail.js:$LINE:$COL',
-            '          at eval (eval at <anonymous> ($TEST/fail.js:$LINE:$COL), <anonymous>:$LINE:$COL)',
-            '          at eval (eval at <anonymous> ($TEST/fail.js:$LINE:$COL), <anonymous>:$LINE:$COL)',
+            '          at eval (eval at <anonymous> ($TEST/fail.js:$LINE:$COL))',
+            '          at eval (eval at <anonymous> ($TEST/fail.js:$LINE:$COL))',
             '          at Test.<anonymous> ($TEST/fail.js:$LINE:$COL)',
             '          [... stack stripped ...]',
             '  ...',

diff --git a/test/too_many.js b/test/too_many.js
@@ -26,8 +26,8 @@ tap.test('array test', function (tt) {
             '      Error: plan != count',
             '          [... stack stripped ...]',
             '          at $TEST/too_many.js:$LINE:$COL',
-            '          at eval (eval at <anonymous> ($TEST/too_many.js:$LINE:$COL), <anonymous>:$LINE:$COL)',
-            '          at eval (eval at <anonymous> ($TEST/too_many.js:$LINE:$COL), <anonymous>:$LINE:$COL)',
+            '          at eval (eval at <anonymous> ($TEST/too_many.js:$LINE:$COL))',
+            '          at eval (eval at <anonymous> ($TEST/too_many.js:$LINE:$COL))',
             '          at Test.<anonymous> ($TEST/too_many.js:$LINE:$COL)',
             '          [... stack stripped ...]',
             '  ...',