Comments should not make exit code incorrect. Fixes #92

tape-testing · Aug 2, 2015 · 8d04af4 · 8d04af4
1 parent c388972
commit 8d04af4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -110,7 +110,7 @@ function createHarness (conf_) {
                 inspectCode(st_);
             });
             st.on('result', function (r) {
-                if (!r.ok) test._exitCode = 1
+                if (!r.ok && typeof r !== 'string') test._exitCode = 1
             });
         })(t);
 

diff --git a/test/exit.js b/test/exit.js
@@ -18,6 +18,7 @@ tap.test('exit ok', function (t) {
         t.same(rs, [
             'TAP version 13',
             'array',
+            'hi',
             { id: 1, ok: true, name: 'should be equivalent' },
             { id: 2, ok: true, name: 'should be equivalent' },
             { id: 3, ok: true, name: 'should be equivalent' },

diff --git a/test/exit/ok.js b/test/exit/ok.js
@@ -2,6 +2,7 @@ var falafel = require('falafel');
 var test = require('../../');
 
 test('array', function (t) {
+    t.comment('hi');
     t.plan(5);
 
     var src = '(' + function () {