-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple fixes #161
Multiple fixes #161
Conversation
Hi @taoqf! Hope you're doing well. I fixed most of the open issues. I will be addressing the outstanding soon. I will merge the changes, myself, but I need your help with one thing. I'd like to enable automatic publishing when a version tag is pushed This will allow me to publish releases when I fix issues. I've added github actions for testing & publishing. It also automatically creates a release, as long as we follow Conventional Commits style commits. With this setup, all we need to do when we have a new version is to run
After this, when we push that commit, github actions will create a release and publish the package to NPM. I just need you to add an NPM token to the repository, which is very easy to setup! What I need from you is for you to:
When you've got that added, please let me know, and I will publish all of these fixes. |
@nonara Done. Thanks so much for all your work. |
Added wrapper for esm over CJS module and removed nonworking separate ESM build (per advice from url below). Note: Essentially a breaking change as `exports` package.json property prevents direct import from files in dist see: https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1
19d5a6c
to
9edd14d
Compare
No problem! Happy to help! |
"prepare": "npm run build" | ||
"--------------- ": "", | ||
"posttest": "yarn run benchmark", | ||
"prepare": "cd test && yarn install" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues Corrected
premises
tag and querySelector() / querySelectorAll() #156Extras
v4.0.0
)This can be technically considered a breaking change for some, as affording proper ESM support requires adding an
exports
field topackage.json
.This is the proper way to handle such support, but it should be released as a new major version, regardless.
For more detail on the approach used and why it's optimal, see:
Note: If a user needs a certain export that is not exported in the main index, he or she can file an issue requesting it, and we try to accommodate