Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency commander to v13 #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jan 4, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
commander ^12.0.0 -> ^13.0.0 age adoption passing confidence

Release Notes

tj/commander.js (commander)

v13.0.0

Compare Source

Added
  • support multiple calls to .parse() with default settings ([#​2299])
  • add .saveStateBeforeParse() and .restoreStateBeforeParse() for use by subclasses ([#​2299])
  • style routines like styleTitle() to add color to help using .configureHelp() or Help subclass ([#​2251])
  • color related support in .configureOutput() for getOutHasColors(), getErrHasColors(), and stripColor() ([#​2251])
  • Help property for minWidthToWrap ([#​2251])
  • Help methods for displayWidth(), boxWrap(), preformatted() et al ([#​2251])
Changed
  • Breaking: excess command-arguments cause an error by default, see migration tips ([#​2223])
  • Breaking: throw during Option construction for unsupported option flags, like multiple characters after single - ([#​2270])
  • Breaking: throw on multiple calls to .parse() if storeOptionsAsProperties: true ([#​2299])
  • TypeScript: include implicit this in parameters for action handler callback ([#​2197])
Deleted
  • Breaking: Help.wrap() refactored into formatItem() and boxWrap() ([#​2251])
Migration Tips

Excess command-arguments

It is now an error for the user to specify more command-arguments than are expected. (allowExcessArguments is now false by default.)

Old code:

program.option('-p, --port <number>', 'port number');
program.action((options) => {
  console.log(program.args);
});

Now shows an error:

$ node example.js a b c
error: too many arguments. Expected 0 arguments but got 3.

You can declare the expected arguments. The help will then be more accurate too. Note that declaring
new arguments will change what is passed to the action handler.

program.option('-p, --port <number>', 'port number');
program.argument('[args...]', 'remote command and arguments'); // expecting zero or more arguments
program.action((args, options) => {
  console.log(args);
});

Or you could suppress the error, useful for minimising changes in legacy code.

program.option('-p, --port', 'port number');
program.allowExcessArguments();
program.action((options) => {
  console.log(program.args);
});

v12.1.0

Compare Source

Added

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

github-actions bot commented Jan 4, 2025

Eslint Check Result

✅ 0 error 0 warning.

Typescript Check Result

❌ 3 errors.

Details

Scope: 3 of 4 workspace projects
packages/preview lint:ts$ tsc --noEmit
packages/parse lint:ts$ tsc --noEmit
packages/parse lint:ts: Done
packages/preview lint:ts: Done
packages/cli lint:ts$ tsc --noEmit
packages/cli lint:ts: src/parse.ts(7,55): error TS2307: Cannot find module 'svg-to-component-parse' or its corresponding type declarations.
packages/cli lint:ts: src/parse.ts(28,24): error TS7006: Parameter 'v' implicitly has an 'any' type.
packages/cli lint:ts: src/preview.ts(18,45): error TS2307: Cannot find module 'svg-to-component-preview' or its corresponding type declarations.
packages/cli lint:ts: Failed
/home/runner/work/svg-to-component/svg-to-component/packages/cli:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  [email protected] lint:ts: `tsc --noEmit`
Exit status 2

UnitTest Check Result

✅ passed.


Commented by Action check pull request #130, last updated on Sun Jan 5 01:22:57 CST 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants